Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Forward SKU as product name when ecommerce events are bundled #47

Merged

Conversation

rmi22186
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

We have a Braze setting Replace SKU as Braze Product Name which works when the customer sends an ecommerce events one by one (default). However, a new feature was added allowing a customer to send all products in a single event. When this is enabled via checking Bundle Commerce Event Data, we do not respect the Replace Sku as Braze Product Name selection. Instead we always use the product name. We should implement this flag so that the expected behavior occurs whether or not Bundle eCommerce Data is selected.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Unit tests also added

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@rmi22186 rmi22186 merged commit 5db53a5 into master-v4 Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants