Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify V4 settings requirement for self hosting #45

Merged
merged 1 commit into from
Oct 18, 2023
Merged

docs: Clarify V4 settings requirement for self hosting #45

merged 1 commit into from
Oct 18, 2023

Conversation

rmi22186
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Add docs to clarify self hosting also requires a V4 selection. This is merging into the master branch

Testing Plan

  • Was this tested locally? If not, explain why.
    This is simply a README update. Copying and pasting the copy that was approved for our docs page.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@rmi22186 rmi22186 merged commit 64fa356 into master Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexs-mparticle alexs-mparticle alexs-mparticle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmi22186 @alexs-mparticle