turn comments

mparticle-integrations · Oct 23, 2024 · f3ce8b9 · f3ce8b9
1 parent 59d0478
commit f3ce8b9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/rollup.test.config.js b/rollup.test.config.js
@@ -1,3 +1,4 @@
+// https://go.mparticle.com/work/SQDSDKS-6875
 import resolve from '@rollup/plugin-node-resolve';
 import commonjs from '@rollup/plugin-commonjs';
 

diff --git a/src/BrazeKit-dev.js b/src/BrazeKit-dev.js
@@ -726,9 +726,11 @@ var constructor = function () {
             userConsentState
         );
 
-        latestUserBrazeConsentString = JSON.stringify(currentConsentPayload);
+        if (!isEmpty(currentConsentPayload)) {
+            latestUserBrazeConsentString = JSON.stringify(
+                currentConsentPayload
+            );
 
-        if (latestUserBrazeConsentString.length) {
             setConsentOnBraze(currentConsentPayload);
         }
     }
@@ -742,7 +744,7 @@ var constructor = function () {
     }
 
     function maybeSetConsentBeforeEventLogged(event) {
-        if (latestUserBrazeConsentString && parsedConsentMappings.length) {
+        if (latestUserBrazeConsentString && !isEmpty(parsedConsentMappings)) {
             var eventConsentState = getEventConsentState(event.ConsentState);
 
             if (!isEmpty(eventConsentState)) {

diff --git a/test/tests.js b/test/tests.js
@@ -1920,7 +1920,7 @@ user.getUserIdentities is not a function,\n`;
             window.braze.user.customAttributeSet.should.equal(false);
         });
 
-        it('user consent should not be updated if a customer does not change his consent before logging an event', function() {
+        it('should not update user consent if a customer does not change consent before logging an event', function() {
             mParticle.forwarder.init({
                 apiKey: '123456',
                 userIdentificationType: 'MPID',
@@ -1968,7 +1968,7 @@ user.getUserIdentities is not a function,\n`;
             window.braze.user.customAttributeSet.should.equal(false);
         });
 
-        it('user consent should be updated if an event has a different consent than the previously set consent', function() {
+        it('should update user consent if an event has a different consent than the previously set consent', function() {
             mParticle.forwarder.init({
                 apiKey: '123456',
                 userIdentificationType: 'MPID',