-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom domain proxy #28
feat: add support for custom domain proxy #28
Conversation
Co-authored-by: Ben Baron <[email protected]>
@ngarg-mparticle any update on testing this? |
// Enable custom domain proxy if provided | ||
if (self.configuration[UAConfigCustomDomainProxyUrl]) { | ||
config.initialConfigURL = self.configuration[UAConfigCustomDomainProxyUrl]; | ||
config.URLAllowList = @[self.configuration[UAConfigCustomDomainProxyUrl]]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we setting URLAllowList
to UAConfigCustomDomainProxyUrl
? I assume this would overwrite the URLAllowList
populated from the default config, which is probably not what we want to do.
Context: I'm from the customer that requested this feature. I will be testing this and the above doesn't seems to be right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShaneQi this change was made following Airship's docs here: https://docs.airship.com/reference/integration/custom-domain-proxy/?groupid=ios-swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShaneQi perhaps a better approach would be to append if URLAllowList already exists? I can look into making that change soon.
Co-authored-by: Shane Qi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f288079
into
mparticle-integrations:development
Summary
Testing Plan