Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add forward screen events config when using an external Braze instance #92

Merged
merged 3 commits into from
Jun 18, 2024
Merged

fix: add forward screen events config when using an external Braze instance #92

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bac57c
adding forward screen events config reading when using an already ini…
v-mamaya Jun 18, 2024
43c9c01
moving collectIDFA setting out of options dictionary to avoid side ef…
v-mamaya Jun 18, 2024
68ac1b3
matching syntax in setting the instance variables
v-mamaya Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions Sources/mParticle-Appboy/MPKitAppboy.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,10 @@ - (void)start {
return;
}

self->forwardScreenViews = self.configuration[@"forwardScreenViews"] && [self.configuration[@"forwardScreenViews"] caseInsensitiveCompare:@"true"] == NSOrderedSame;

self->collectIDFA = self.configuration[@"ABKCollectIDFA"] && [self.configuration[@"ABKCollectIDFA"] caseInsensitiveCompare:@"true"] == NSOrderedSame;

if (self->collectIDFA) {
[self->appboyInstance setIdentifierForAdvertiser:[self advertisingIdentifierString]];
}
Expand Down Expand Up @@ -415,25 +419,13 @@ - (void)start {
}
}];

self->collectIDFA = self.configuration[@"ABKCollectIDFA"] && [self.configuration[@"ABKCollectIDFA"] caseInsensitiveCompare:@"true"] == NSOrderedSame;
if (self->collectIDFA) {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wincompatible-pointer-types"
optionsDictionary[ABKIDFADelegateKey] = (id)self;
#pragma clang diagnostic pop
}

if (self.host.length) {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wincompatible-pointer-types"
optionsDictionary[ABKEndpointKey] = self.host;
#pragma clang diagnostic pop
}

if (self.configuration[@"forwardScreenViews"]) {
self->forwardScreenViews = [self.configuration[@"forwardScreenViews"] caseInsensitiveCompare:@"true"] == NSOrderedSame;
}

if (optionsDictionary.count == 0) {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wincompatible-pointer-types"
Expand Down