Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Setting urlDelegate on Braze instance #90

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: Setting urlDelegate on Braze instance #90

merged 1 commit into from
May 28, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

  • We had a class method to set a Braze delegate, but it ultimately wasn't being set on the instance. This resolves that issue.
  • Also I made all delegates strong references as they're static anyway and weak can cause potential issues between setting and using depending on how the customer stores the reference.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Confirmed with breakpoints that it is correctly being set now.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

BrandonStalnaker
BrandonStalnaker approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 changed the title Fix setting urlDelegate on Braze instance fix: Setting urlDelegate on Braze instance May 28, 2024
@einsteinx2 einsteinx2 merged commit 596c250 into development May 28, 2024
2 of 3 checks passed
@einsteinx2 einsteinx2 deleted the fix/6502-set-custom-url-delegate branch May 28, 2024 16:00
mparticle-automation added a commit that referenced this pull request May 28, 2024
@mparticle-automation
chore(release): 8.6.1 [skip ci]
ee542cb 
## [8.6.1](v8.6.0...v8.6.1) (2024-05-28)

### Bug Fixes

* Setting urlDelegate on Braze instance ([#90](#90)) ([596c250](596c250))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 8.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@einsteinx2 @mparticle-automation @BrandonStalnaker