fix: Deleting property stripping from product when sent unbundled (#86)

* Fixing property stripping from product + fixing associated test * adding a sample product category to the test case
mparticle-integrations · Feb 7, 2024 · d0b477b · d0b477b
1 parent e3d887e
commit d0b477b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Sources/mParticle-Appboy/MPKitAppboy.m b/Sources/mParticle-Appboy/MPKitAppboy.m
@@ -467,7 +467,7 @@ - (MPKitExecStatus *)routeCommerceEvent:(MPCommerceEvent *)commerceEvent {
                 }
 
                 // Strips key/values already being passed to Appboy, plus key/values initialized to default values
-                keys = @[kMPExpProductSKU, kMPProductCurrency, kMPExpProductUnitPrice, kMPExpProductQuantity, kMPProductAffiliation, kMPExpProductCategory, kMPExpProductName];
+                keys = @[kMPExpProductSKU, kMPProductCurrency, kMPExpProductUnitPrice, kMPExpProductQuantity];
                 [properties removeObjectsForKeys:keys];
 
                 [appboyInstance logPurchase:product.sku

diff --git a/mParticle_AppboyTests/mParticle_AppboyTests.m b/mParticle_AppboyTests/mParticle_AppboyTests.m
@@ -410,6 +410,7 @@ - (void)testlogPurchaseCommerceEvent {
     XCTAssertEqualObjects(mockClient, [kit appboyInstance]);
 
     MPProduct *product = [[MPProduct alloc] initWithName:@"product1" sku:@"1131331343" quantity:@1 price:@13];
+    product.category = @"category1";
 
     MPCommerceEvent *event = [[MPCommerceEvent alloc] initWithAction:MPCommerceEventActionPurchase product:product];
     event.customAttributes = @{@"testKey" : @"testCustomAttValue"};
@@ -430,7 +431,9 @@ - (void)testlogPurchaseCommerceEvent {
                                        @"Total Amount" : @13.00,
                                        @"Total Product Amount" : @"13",
                                        @"Tax Amount" : @3,
-                                       @"Transaction Id" : @"foo-transaction-id"
+                                       @"Transaction Id" : @"foo-transaction-id",
+                                       @"Name" : @"product1",
+                                       @"Category" : @"category1"
                        }];
 
     MPKitExecStatus *execStatus = [kit logBaseEvent:event];