Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #33] Replaced "www/" Cordova paths by Capacitor's "public/" ones #35

Merged
merged 9 commits into from
Jul 8, 2021
Merged

[Fixes #33] Replaced "www/" Cordova paths by Capacitor's "public/" ones #35

merged 9 commits into from
Jul 8, 2021

Conversation

Clovel
Copy link

@Clovel Clovel commented Jun 14, 2021

What I did

  • Replaced "www/" package paths by "public/". Cordova used to use "www/" paths whereas Capacitor uses "public/".
  • Updated the README.md's instructions accordingly.

Bonus

  • Updated the CONTRIBUTING.md instructions on what files to edit when contributing.
  • Fixed unit tests by implementing a missing function in testUtils.ts.

What I tested

  • CodePush + Capacitor + Ionic + React
  • Tested on Android (for now. iOS test coming soon.)

Clovel added 8 commits June 14, 2021 18:40
@Clovel
[mpaghq#33] Replaced hard coded "www" by Capacitor's "public" path
b6d61a8 
Signed-off-by: Clovis Durand <[email protected]>
@Clovel
[mpaghq#33] Compiled the project
f690a50 
Signed-off-by: Clovis Durand <[email protected]>
@Clovel
Fixed CONTRIBUTING.md's instructions on file editions
42989e3 
Signed-off-by: Clovis Durand <[email protected]>
@Clovel
Implemented missing TestUtil method
7f9470a 
Signed-off-by: Clovis Durand <[email protected]>
@Clovel
[DEBUG] Added logs to the preInstall java function
819489d 
Signed-off-by: Clovis Durand <[email protected]>
@Clovel
[mpaghq#33] Replaced "www/" by "public/" in the README.md's CodePush …
920f949 
…commands

Signed-off-by: Clovis Durand <[email protected]>
@Clovel
Revert "[DEBUG] Added logs to the preInstall java function"
17a0bff 
This reverts commit 819489d.
@Clovel
[mpaghq#33] Added instructions about releasing bundles in the README.md
d2cb43a 
Signed-off-by: Clovis Durand <[email protected]>
@Clovel Clovel changed the title [Fixes #33] Replaced "www/" Cordova paths by Capacitor's "public/" ones [Fixes mapiacompany#33] Replaced "www/" Cordova paths by Capacitor's "public/" ones Jun 14, 2021
@Clovel Clovel changed the title [Fixes mapiacompany#33] Replaced "www/" Cordova paths by Capacitor's "public/" ones [Fixes #33] Replaced "www/" Cordova paths by Capacitor's "public/" ones Jun 14, 2021
@Clovel Clovel mentioned this pull request Jun 16, 2021
Closed
@Clovel
Copy link
Author

Clovel commented Jun 16, 2021

We should link this w/ issue #33.

@Clovel
Copy link
Author

Clovel commented Jun 16, 2021

Setting this MR as WIP. Latest iOS test shows that my fixes aren't sufficient.

To be clear :

  • This works on Android
  • This does not work on iOS 14.5

@Clovel Clovel changed the title [Fixes #33] Replaced "www/" Cordova paths by Capacitor's "public/" ones [WIP][Fixes #33] Replaced "www/" Cordova paths by Capacitor's "public/" ones Jun 16, 2021
@o-alexandrov
Copy link

closes #33 #21
it'll probably close #21 also, as it seems to have the same path-related issues

@Clovel Clovel changed the title [WIP][Fixes #33] Replaced "www/" Cordova paths by Capacitor's "public/" ones [Fixes #33] Replaced "www/" Cordova paths by Capacitor's "public/" ones Jun 21, 2021
@Clovel Clovel force-pushed the fix/wwwToPublic branch from c3c28dd to d4015b3 Compare June 23, 2021 15:56
@Clovel Clovel mentioned this pull request Jun 23, 2021
Merged
@leo6104 leo6104 merged commit 112a3ff into mpaghq:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Clovel @o-alexandrov @leo6104