Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubmit cancelled/deleted jobs #29

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Resubmit cancelled/deleted jobs #29

merged 5 commits into from
Oct 8, 2024

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Sep 19, 2024

Fixes #26

  • adds a view to "retry" cancelled or deleted jobs. The retry is more "create a new job" as the API doesn't have anything in this regard
  • while the template uses a form, didn't go the full Django form way as we don't need additional validation
  • uses a separate view rather then the ModelViewSet CopyView because of various hoops and rabbit holes that introduces

To-Do:

  • add additional checks
  • link to the view from the translation page message
  • retry view tests (permissions, post)
  • stretch: look at surfacing cancellation reason in the report, if possible could not find a sensible way to do this

@zerolab zerolab marked this pull request as draft September 19, 2024 09:46
@zerolab zerolab changed the title Retry job Resubmit cancelled/deleted jobs Sep 19, 2024
@stevejalim
Copy link
Collaborator

Heya @zerolab - not chasing you, but if you want me to take a look at this now, do let me know. Don't want you to be blocked waiting for review from me

@zerolab
Copy link
Collaborator Author

zerolab commented Sep 30, 2024

🤦‍♂️ I was so convinved I've pinged you to take this for a test. Please do.
Will push the test today/tomorrow

@zerolab zerolab marked this pull request as ready for review October 3, 2024 17:52
@stevejalim stevejalim self-requested a review October 8, 2024 10:28
@stevejalim
Copy link
Collaborator

Test driven locally and it's lovely to use. Thank you for this @zerolab - I'm sure it will help me recover well from any process-related footguns I cause :)

Copy link
Collaborator

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an r+ from me!

Thanks for this addition @zerolab - we really appreciate it and it'll be very useful!

@zerolab zerolab requested a review from stevejalim October 8, 2024 12:49
@zerolab
Copy link
Collaborator Author

zerolab commented Oct 8, 2024

argh, did not get the notification and re-requested your review after you reviewd it.
Will merge and submit the description callback PR (somehow missed that) and I think that is all on the list

@zerolab zerolab merged commit 5d3a79a into main Oct 8, 2024
7 checks passed
@zerolab zerolab deleted the retry-job branch October 8, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow resubmitting cancelled/unsuccessful jobs
2 participants