Remove obsolete Gitpod files #19062
Merged
Remove obsolete Gitpod files #19062
+0
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR mozilla#11300 Gitpod support got introduced, but we re-evaluated that decision in mozilla#11732. In PR mozilla#11800 the support was partially reverted, but the actual Gitpod files were kept to not outright break potential workflows because at the time we were not sure if, and if so how often, Gitpod was actually used for contributing to PDF.js. However, in addition to the concerns mentioned in mozilla#11732 after five years we haven't seen any contributions that clearly originated from Gitpod, and the files have not been updated after e.g. PR mozilla#11807 and PR mozilla#17913 because it's not a workflow that we maintain or are able to test (nor have we seen Gitpod community contributions for this). This commit therefore removes the remaining Gitpod files to reduce maintainance burden for PDF.js. Note that users of Gitpod can still contribute to PDF.js via the platform; we just don't provide/manage workspace files from this repository anymore.
timvandermeij
force-pushed
the
gitpod
branch
from
c90c038
to
093485d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #11300 Gitpod support got introduced, but we re-evaluated that decision in #11732. In PR #11800 the support was partially reverted, but the actual Gitpod files were kept to not outright break potential workflows because at the time we were not sure if, and if so how often, Gitpod was actually used for contributing to PDF.js.
However, in addition to the concerns mentioned in #11732 after five years we haven't seen any contributions that clearly originated from Gitpod, and the files have not been updated after e.g. PR #11807 and PR #17913 because it's not a workflow that we maintain or are able to test (nor have we seen Gitpod community contributions for this).
This commit therefore removes the remaining Gitpod files to reduce maintainance burden for PDF.js. Note that users of Gitpod can still contribute to PDF.js via the platform; we just don't provide/manage workspace files from this repository anymore.