-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use flakes to run firefox-nightly without manually including overlays. #307
Open
nbp
wants to merge
1
commit into
mozilla:master
Choose a base branch
from
nbp:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
{ | ||
inputs = { | ||
nixpkgs.url = "nixpkgs/nixos-unstable"; | ||
# nixpkgs-mozilla.url = "/local/path/to/nixpkgs-mozilla"; | ||
nixpkgs-mozilla.url = "github:mozilla/nixpkgs-mozilla/master"; | ||
}; | ||
|
||
outputs = {nixpkgs, nixpkgs-mozilla, ...}: | ||
let | ||
latest = (import nixpkgs { | ||
overlays = [ nixpkgs-mozilla.overlays.firefox ]; | ||
system = "x86_64-linux"; | ||
}).latest; | ||
in { | ||
packages."x86_64-linux".default = latest.firefox-nightly-bin; | ||
packages."x86_64-linux".firefox-nightly = latest.firefox-nightly-bin; | ||
packages."x86_64-linux".firefox-beta = latest.firefox-beta-bin; | ||
packages."x86_64-linux".firefox-release = latest.firefox-release-bin; | ||
packages."x86_64-linux".firefox-esr = latest.firefox-esr-bin; | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
inputs = { | ||
nixpkgs.url = "nixpkgs/nixos-22.11"; | ||
# nixpkgs-mozilla.url = "/local/path/to/nixpkgs-mozilla/flakes"; | ||
nixpkgs-mozilla.url = "github:mozilla/nixpkgs-mozilla/master?dir=flakes"; | ||
nixpkgs-mozilla.inputs.nixpkgs.follows = "nixpkgs"; | ||
}; | ||
|
||
outputs = {nixpkgs-mozilla, ...}: { | ||
inherit (nixpkgs-mozilla) packages; | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
inputs = { | ||
nixpkgs.url = "nixpkgs/nixos-unstable"; | ||
# nixpkgs-mozilla.url = "/local/path/to/nixpkgs-mozilla/flakes"; | ||
nixpkgs-mozilla.url = "github:mozilla/nixpkgs-mozilla/master?dir=flakes"; | ||
nixpkgs-mozilla.inputs.nixpkgs.follows = "nixpkgs"; | ||
}; | ||
|
||
outputs = {nixpkgs-mozilla, ...}: { | ||
inherit (nixpkgs-mozilla) packages; | ||
}; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? users can just
--override-input nixpkgs nixpkgs/nixos-22.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another option, yes, but this would still require
?dir=flakes
, as there is nonixpkgs
input to the rootflake.nix
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think channel specific flakes are unnecessary bloat and it can't be guaranteed that they will always exist many years in the future, while override-input is future proof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing a bit, it seems that the following are already working:
Thanks for the feedback, I will remove the 2 flake.nix which are simply replacing nixpkgs input and add this one as example in the README.
Unfortunately, the
nix run
command does not work yet, unless we override again the input, as thepname
change is not yet part ofmozilla/nixpkgs-mozilla
, but it can temporarily be achieved with: