Track login next URL as part of OIDC state #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We support multiple parallel login processes by using a dictionary for `oidc_state`. With only a single shared `oidc_login_next` field in the session, all login processes will redirect the user to the next URL set by the login process they initiated last. This behavior seems confusing and not that useful. By storing the login next URL as part of the state, we can have each login process redirect to the next URL provided at its initiation. Also, we get the benefit that the login next URL for that login process will not be lingering around in the session anymore, as the whole state for that login process, including the login next URL, will be removed by the OIDC callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support multiple parallel login processes by using a dictionary
for
oidc_state.With only a single shared
oidc_login_nextfield in the session,all login processes will redirect the user to the next URL set by
the login process they initiated last.
This behavior seems confusing and not that useful.
By storing the login next URL as part of the state, we can have each
login process redirect to the next URL provided at its initiation.
Also, we get the benefit that the login next URL for that login process
will not be lingering around in the session anymore, as the whole state
for that login process, including the login next URL, will be removed by
the OIDC callback.