This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feat: remove hpkp tests #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
LGTM.
Only nit: There is one more mention of HPKP in the tests:
http-observatory/httpobs/tests/unittests/test_headers.py
Lines 1185 to 1186 in f832ff9
|
Thank you!
Thanks, noticed this yesterday but wasn't sure what to do with it - updated it now. It's all pretty elementary anyway because IIRC from trying earlier, I'll need to update these tests when I update the HSTS preload list. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HPKP is now totally obsolete, so removing it entirely