feat(react): Convert third party auth 'Set password' page to React #18044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZoog
commented
Nov 20, 2024
| @@ -128,7 +128,7 @@ const getReactRouteGroups = (showReactApp, reactRoute) => { | |||
| 'post_verify/third_party_auth/callback', | |||
| 'post_verify/third_party_auth/set_password', | |||
| ]), | |||
| fullProdRollout: false, | |||
| fullProdRollout: true, | |||
There was a problem hiding this comment.
This won't roll out until we also turn the feature flag on. I'll double check that's set up properly.
There was a problem hiding this comment.
PR on SRE side: https://github.com/mozilla-it/webservices-infra/pull/3382
LZoog
commented
Nov 20, 2024
LZoog
commented
Nov 20, 2024
LZoog
commented
Nov 20, 2024
packages/fxa-settings/src/pages/PostVerify/SetPassword/container.tsx
Outdated
Show resolved
Hide resolved
4 tasks
LZoog
force-pushed
the
FXA-6651
branch
2 times, most recently
from
6f4e0d0
to
13a73ee
Compare
bcolsson
reviewed
Nov 21, 2024
vpomerleau
reviewed
Nov 21, 2024
bcolsson
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Do we need this empty file?
vbudhram
reviewed
Nov 21, 2024
| @@ -318,6 +320,10 @@ const AuthAndAccountSetupRoutes = ({ | |||
| path="/post_verify/third_party_auth/callback/*" | |||
| {...{ flowQueryParams }} | |||
| /> | |||
| <SetPasswordContainer | |||
| path="/post_verify/finish_account_setup/set_password/*" | |||
There was a problem hiding this comment.
Should this be third_party_auth/set_password
| }, | ||
| }); | ||
|
|
||
| if (isOAuthNative) { |
There was a problem hiding this comment.
Would you not be able to use the handleNavigation in signin utils?
There was a problem hiding this comment.
We might be able to, but we'd have to modify some pieces in it to send up the sync engines. (That might be better though 🤔)
Because: * There are data-sharing problems with this page currently being on Backbone while other pages in the flow are in React, causing a double sign-in for all 'Set password' flows, plus the inability to sign into Sync and maintain CWTS choices for desktop oauth * We want to move completely over from Backbone to React This commit: * Creates 'post_verify/third_party_auth/set_password' page in React with container component * Sends web channel messages up to Sync after password create success * Shares form logic with Signup, includes useSyncEngine hook for DRYness * Changes InlineRecoveryKeySetup to check local storage instead of location state, which prevents needing to prop drill as users should always be signed in and these values available in local storage on this page * Returns authPW and unwrapBKey from create password in auth-client closes FXA-6651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
closes FXA-6651
TODO: check that this works rebased on Vijay's branch, unit tests for SetPassword + SetPassword container
**I propose creating a follow up issue for moving some tests out from Signup/Signup container and into FormSetupAccount/useSyncEngines and creating stories for FormSetupAccount then, the diff is already large and we do have coverage for these, they're just not in their refactored components. **