Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use secrets in bqetl_marketing_suppression_list DAG #6247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −7
Open

Use secrets in bqetl_marketing_suppression_list DAG #6247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...od/marketing_suppression_list_external/campaign_monitor_suppression_list_v1/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ labels:
owner1: leli
scheduling:
dag_name: bqetl_marketing_suppression_list
arguments:
- --api_key={{ var.value.campaign_monitor_api_key }}
- --client_id={{ var.value.campaign_monitor_client_id }}
secrets:
- deploy_target: CAMPAIGN_MONITOR_API_KEY
key: bqetl_marketing_suppression_list__campaign_monitor_api_key
- deploy_target: CAMPAIGN_MONITOR_CLIENT_ID
key: bqetl_marketing_suppression_list__campaign_monitor_client_id
bigquery: null
references: {}
2 changes: 2 additions & 0 deletions ...ed-prod/marketing_suppression_list_external/campaign_monitor_suppression_list_v1/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ def download_suppression_list(
@click.command
@click.option(
"--api_key",
envvar='CAMPAIGN_MONITOR_API_KEY',
required=True,
help="Campaign Monitor API key to use for authentication.",
)
Expand All @@ -111,6 +112,7 @@ def download_suppression_list(
)
@click.option(
"--client_id",
envvar='CAMPAIGN_MONITOR_CLIENT_ID',
required=True,
help="Client Id for Campaign Monitor.",
)
Expand Down
10 changes: 6 additions & 4 deletions ...ppression_list_external/send_suppression_list_update_to_campaign_monitor_v1/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@ owners:
- [email protected]
labels:
incremental: true
owner1: leli
owner1: cbeck
scheduling:
dag_name: bqetl_marketing_suppression_list
arguments:
- --api_key={{ var.value.campaign_monitor_api_key }}
- --client_id={{ var.value.campaign_monitor_client_id }}
secrets:
- deploy_target: CAMPAIGN_MONITOR_API_KEY
key: bqetl_marketing_suppression_list__campaign_monitor_api_key
- deploy_target: CAMPAIGN_MONITOR_CLIENT_ID
key: bqetl_marketing_suppression_list__campaign_monitor_client_id
depends_on:
- task_id: marketing_suppression_list_external__campaign_monitor_suppression_list__v1
dag_name: bqetl_marketing_suppression_list
Expand Down
2 changes: 2 additions & 0 deletions ...ng_suppression_list_external/send_suppression_list_update_to_campaign_monitor_v1/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,13 @@ def store_data_in_bigquery(data, schema, destination_project, destination_table_
@click.command
@click.option(
"--api_key",
envvar='CAMPAIGN_MONITOR_API_KEY',
required=True,
help="Campaign Monitor API key to use for authentication.",
)
@click.option(
"--client_id",
envvar='CAMPAIGN_MONITOR_CLIENT_ID',
required=True,
help="Client Id for Campaign Monitor.",
)
Expand Down