Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh: update the font stack and headline weight #15528

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

craigcook
Copy link
Member

One-line summary

After some progress on #15397 we decided to eschew variable fonts for the time being, but we still need to switch to semibold for headlines to match current designs.

I also updated the font stack; I think sans-serif is a better fallback for the semi-slab Mozilla Headline and couldn't really find a suitable serif system font.

@craigcook craigcook added Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less Refresh 🦖 Work related to the 2024 site refresh labels Nov 20, 2024
@craigcook craigcook requested a review from a team as a code owner November 20, 2024 18:27
@craigcook craigcook force-pushed the m24-fonts branch 2 times, most recently from 280a829 to 87c363b Compare November 21, 2024 19:10
@craigcook
Copy link
Member Author

craigcook commented Nov 21, 2024

Marking Do Not Merge for the moment so I can add #15542 to this PR

#15542 turns out to be more complicated than I thought, better to unblock this simpler PR and handle the other thing separately.

Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ 🤳

@stephaniehobson stephaniehobson merged commit dd28ad5 into mozilla:main Nov 23, 2024
5 checks passed
@craigcook craigcook deleted the m24-fonts branch November 26, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review Refresh 🦖 Work related to the 2024 site refresh Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants