Fix backport records behaviour with group check setting (#1384)

mozilla-services · Feb 1, 2022 · 5cd1c21 · 5cd1c21
1 parent da9a912
commit 5cd1c21
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/commands/backport_records.py b/commands/backport_records.py
@@ -134,8 +134,6 @@ def backport_records(event, context, **kwargs):
 
     has_autoapproval = not signed_dest[0].get(
         "to_review_enabled", signer_config["to_review_enabled"]
-    ) and not signed_dest[0].get(
-        "group_check_enabled", signer_config["group_check_enabled"]
     )
     if has_autoapproval:
         # Approve the changes.

diff --git a/tests/test_backport_records.py b/tests/test_backport_records.py
@@ -193,7 +193,7 @@ def test_pending_changes(self):
                 "capabilities": {
                     "signer": {
                         "to_review_enabled": False,
-                        "group_check_enabled": False,
+                        "group_check_enabled": True,
                         "resources": [
                             {
                                 "source": {