Merge pull request #1112 from mozilla-services/disable-safe-headers

Disable safe headers by default in backport lambda
mozilla-services · Sep 15, 2020 · 3752b8c · 3752b8c
2 parents 020740c + c308c7b
commit 3752b8c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -65,7 +65,7 @@ Environment config:
 - ``BACKPORT_RECORDS_DEST_COLLECTION``:collection id to copy records to (default: same as source collection)
 - ``REQUESTS_TIMEOUT_SECONDS``: Connection/Read timeout in seconds (default: ``2``)
 - ``REQUESTS_NB_RETRIES``: Number of retries before failing (default: ``4``)
-- ``SAFE_HEADERS``: Add concurrency control headers to update requests (default: ``true``)
+- ``SAFE_HEADERS``: Add concurrency control headers to update requests (default: ``false``)
 
 Example:
 

diff --git a/commands/backport_records.py b/commands/backport_records.py
@@ -40,7 +40,7 @@ def backport_records(event, context, **kwargs):
         os.getenv("BACKPORT_RECORDS_DEST_COLLECTION", source_collection),
     )
     safe_headers = event.get(
-        "safe_headers", config("SAFE_HEADERS", default=True, cast=bool)
+        "safe_headers", config("SAFE_HEADERS", default=False, cast=bool)
     )
 
     if source_bucket == dest_bucket and source_collection == dest_collection:

diff --git a/tests/test_backport_records.py b/tests/test_backport_records.py
@@ -110,6 +110,7 @@ def test_outdated_records_are_overwritten(self):
         backport_records(
             event={
                 "server": self.server,
+                "safe_headers": True,
                 "backport_records_source_auth": self.auth,
                 "backport_records_source_bucket": self.source_bid,
                 "backport_records_source_collection": self.source_cid,