finish off Go 1.22 upgrade #926
Conversation
jmhodges
force-pushed
the
finish-golang-1.22
branch
2 times, most recently
from
0ffdbcc to
e6c630f
Compare
jmhodges
force-pushed
the
finish-golang-1.22
branch
5 times, most recently
from
0e2f46a to
23cb500
Compare
This patch cleans up some stragglers in the CircleCI config that were still running on 1.19. We also change `go.mod` to include the patch portion of the Go version. Including `x.y.z`, not just `x.y` is what the Go 1.22 tooling (and, I believe 1.21) does and expects. If we don't include the patch version, various third party tools like GitHub's CodeQL can break (see github/codeql#15647 for the last time I ran into this). This go.mod version change is actually what led me to the other missing CircleCI version bumps as changing go.mod broke those CircleCI jobs. Along the way, we remove some dependency installations from the linting CircleCI job. While future linting maybe need these dependencies, the current ones do not. I've made AUT-158 to consolidate our go linting stuff and avoid some of these problems. Some (not all) of the rationale for AUT-158 will be mooted by a move to GitHub Actions. Along the way, I also ran `go mod tidy` which correctly noted that the the google/uuid dep is now a direct dep. Hilariously, this is the change I did first. do less work in the lint-vet-fmt job
jmhodges
force-pushed
the
finish-golang-1.22
branch
from
23cb500 to
a59c542
Compare
|
Sorry to request the re-review, but I realized we could just not install deps at all in the linting CircleCI job. Have simplified the code and corrected the PR summary and commit message. |
Can you clarify why this is? |
The apt dependencies that were being installed aren't actually being used in any of the linting processes, so they're irrelevant. Once you remove those, the failures of |
|
Specifically, the errors are here: Note the commit they're on was when I flipped from bookworm to the go CircleCI image. |
This patch cleans up some stragglers in the CircleCI config that were
still running on 1.19.
We also change
go.modto include the patch portion of the Go version.Including
x.y.z, not justx.yis what the Go 1.22 tooling (and, Ibelieve 1.21) does and expects. If we don't include the patch version,
various third party tools like GitHub's CodeQL can break (see
github/codeql#15647 for the last time I ran
into this). This go.mod version change is actually what led me to the
other missing CircleCI version bumps as changing go.mod broke those
CircleCI jobs.
Along the way, we remove some dependency installations from the linting
CircleCI job. While future linting maybe need these dependencies, the
current ones do not.
I've made AUT-158 to consolidate our go linting stuff and avoid some of
these problems. Some (not all) of the rationale for AUT-158 will be
mooted by a move to GitHub Actions.
Along the way, I also ran
go mod tidywhich correctly noted that thethe google/uuid dep is now a direct dep. Hilariously, this is the change
I did first.