create working CODEOWNERS file #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhodges
force-pushed
the
codeowners
branch
6 times, most recently
from
7769482 to
5ad5be0
Compare
We would like to have code reviewers automatically alerted and assigned when PRs are posted to autograph codebases. This is the next step towards that for the autograph repo. One this merge, we'll enable the automatic assignation in the GitHub repo settings (one day, we'll have terraform for those settings, I hope). Autograph is going to use the @mozilla-services/autograph-devs GitHub team to provide automatic assignation of code reviewers in autograph. These folks are expected to provide timely reviews of code coming into autograph. See the autograph code review Confluence page for more. As a back up and in order to provide some escape valves, we also have a @mozilla-services/autograph-mergers. This team is folks who are trusted to merge code but can't provide timely reviews like our SREs. This may not be a team that we keep around in the future, but given our current team size and volatility, it's a good back up. Finally, the `addons.mozilla.org` teams has previously requested alerts when code is changed in `signer/xpi`. We provide that here using the same GitHub team as the one used in the mozilla/addons-server CODEOWNERS. Updates AUT-18
bhearsum
approved these changes
Jul 16, 2024
oskirby
approved these changes
Jul 16, 2024
|
@jmhodges FYI: After I merged this we're seeing this error: ...on https://github.com/mozilla-services/autograph/blob/main/.github/CODEOWNERS Did we want https://github.com/orgs/mozilla/teams/addons-amo-engineering for this? |
bhearsum
added a commit
to bhearsum/autograph-edge
that referenced
this pull request
Jul 17, 2024
This is the same as what we've [added in the main Autograph repo](mozilla-services/autograph#922) except there's no need to look in addons folks.
This was referenced Jul 17, 2024
bhearsum
added a commit
to bhearsum/autograph-edge
that referenced
this pull request
Jul 18, 2024
This is the same as what we've [added in the main Autograph repo](mozilla-services/autograph#922) except there's no need to look in addons folks.
bhearsum
added a commit
to mozilla-services/autograph-edge
that referenced
this pull request
Jul 18, 2024
This is the same as what we've [added in the main Autograph repo](mozilla-services/autograph#922) except there's no need to look in addons folks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to have code reviewers automatically alerted and assigned
when PRs are posted to autograph codebases. This is the next step
towards that for the autograph repo. One this merge, we'll enable the
automatic assignation in the GitHub repo settings (one day, we'll have
terraform for those settings, I hope).
Autograph is going to use the @mozilla-services/autograph-devs GitHub
team to provide automatic assignation of code reviewers in autograph.
These folks are expected to provide timely reviews of code coming into
autograph. See the autograph code review Confluence page for more.
As a back up and in order to provide some escape valves, we also have a
@mozilla-services/autograph-mergers. This team is folks who are trusted
to merge code but can't provide timely reviews like our SREs. This may
not be a team that we keep around in the future, but given our current
team size and volatility, it's a good back up.
Finally, the
addons.mozilla.orgteams has previously requested alertswhen code is changed in
signer/xpi. We provide that here using thesame GitHub team as the one used in the mozilla/addons-server
CODEOWNERS.
Updates AUT-18