require db for contentsignaturepki gnight #1065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmhodges
commented
Nov 12, 2024
jmhodges
commented
- require a database in contentsignaturepki
- refactor tests in contentsignaturepki
- pass in test handler but now hsm errors happen
- more testhandler refactor
- add truncates to contentsignaturepki
- always rebuild docker image for unit tests
- k
- almost done
- add ClearDatabase and a new test to make sure i didnt break the hsm integration
- rename
Got confused. Need better testing scipt.
jmhodges
force-pushed
the
require-db-for-contentsignaturepki-gnight
branch
from
3642362 to
f50efb5
Compare
Plus error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.