reverting trust_remote_code changes to address in a distinct pr

mozilla-ai · Aug 6, 2024 · 53b5ba2 · 53b5ba2
1 parent 462caf0
commit 53b5ba2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/src/lm_buddy/configs/huggingface.py b/src/lm_buddy/configs/huggingface.py
@@ -100,7 +100,7 @@ def validate_adapter_args(cls, config: "AdapterConfig"):
         # Filter fields to those found on the PeftConfig
         extra_fields = config.model_fields_set.difference(allowed_fields)
         if extra_fields:
-            raise ValueError(f"Unknowon arguments for {peft_type} adapter: {extra_fields}")
+            raise ValueError(f"Unknown arguments for {peft_type} adapter: {extra_fields}")
 
         return config
 

diff --git a/src/lm_buddy/configs/jobs/lm_harness.py b/src/lm_buddy/configs/jobs/lm_harness.py
@@ -47,7 +47,6 @@ class LMHarnessJobConfig(JobConfig):
     model: AutoModelConfig | LocalChatCompletionsConfig
     evaluation: LMHarnessEvaluationConfig
     quantization: QuantizationConfig | None = None
-    trust_remote_code: bool = False
 
     def asset_paths(self) -> list[AssetPath]:
         match self.model:

diff --git a/src/lm_buddy/jobs/evaluation/lm_harness.py b/src/lm_buddy/jobs/evaluation/lm_harness.py
@@ -50,7 +50,7 @@ def load_harness_model(config: LMHarnessJobConfig) -> HFLM | OpenaiCompletionsLM
                 tokenizer=model_path,
                 peft=peft_path,
                 device="cuda" if torch.cuda.device_count() > 0 else "cpu",
-                trust_remote_code=config.trust_remote_code,
+                trust_remote_code=model_config.trust_remote_code,
                 dtype=config.model.torch_dtype if config.model.torch_dtype else "auto",
                 **quantization_kwargs,
             )