Noetic release

[ahcorde]

Following the guidelines to migrate packages to noetic

• Python3 changes

• import setup from setuptools instead of distutils-core

• Bump CMake version to avoid CMP0048 warning
  This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.

[v4hn]

@ahcorde Looks like your python3 change (for some reason?) made the test fail. Can you have a look?

[ahcorde]

Noetic should work on Ubuntu Focal and Python3. In the error I see that tests are being launched with Python2.7

<testsuite errors="1" failures="0" name="unittest.suite.TestSuite" tests="3" time="0.046"><testcase classname="__main__.TestSRDFParser" name="test_complex_srdf" time="0.0229" /><testcase classname="__main__.TestSRDFParser" name="test_full_srdf" time="0.0024"><error type="AttributeError">'unicode' object has no attribute 'nodeType'
  File "/usr/lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File "/root/ros_ws/src/srdfdom/test/test.py", line 147, in test_full_srdf
    self.assertTrue(xml_matches(robot.to_xml_string(),expected))
  File "/root/ros_ws/src/srdfdom/test/test.py", line 75, in xml_matches
    return xml_matches(a, parseString(b).documentElement)
  File "/root/ros_ws/src/srdfdom/test/test.py", line 76, in xml_matches
    if a.nodeType == xml.dom.Node.DOCUMENT_NODE:

[v4hn]

In the error I see that tests are being launched with Python2.7

I assume you want to say your patch is not python2/3 compatible?
In that case I just pushed a new branch noetic-devel and retargeted your request.

[ahcorde]

I have created a source job to be able to test it in the buildfarm in the right conditions

[v4hn]

Thanks, MoveIt's own CI is currently not yet up to the task.

I guess we want to get our CI ready for it before merging this though.

[rhaschke]

There is not even a ROS Noetic docker image available: https://hub.docker.com/_/ros?tab=tags&page=1&name=noetic
So, we cannot yet setup our CI. I asked @sloretz at last ROSCon already to provide this infrastructure.

[ahcorde]

I'm working in to unblock some metapackages to be able to create the Docker images.

[rhaschke]

Is there a list of pending packages somewhere?

[ahcorde]

http://repositories.ros.org/status_page/blocked_releases_noetic.html?s=6&r=1

[v4hn]

That's quite a list... wow. Thank you for working on it.

Is there also a list of all packages required for the docker image?

[ahcorde]

Here you can find the specific list for the metapackages repository: http://repositories.ros.org/status_page/blocked_releases_noetic.html?q=id%3D%22metapackages%22&s=6&r=1

[v4hn]

@rhaschke you just merged this in the new noetic-devel branch.
I agree that it would be much better to have the melodic-devel branch python3 compatible!

Feel free to merge it back there and drop the noetic branch again for now.

[rhaschke]

For now, melodic-devel and noetic-devel are on par.

[sloretz]

There is not even a ROS Noetic docker image available: https://hub.docker.com/_/ros?tab=tags&page=1&name=noetic
So, we cannot yet setup our CI. I asked @sloretz at last ROSCon already to provide this infrastructure.

@ahcorde added a source entry for srdfdom enabling pull request jobs for this repo in ros/rosdistro#24326 . Assuming this repo is setup for PR testing on the ROS buildfarm, PRs will be tested by this PR job, and the noetic-devel branch will be tested by this dev job.