Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename HAVE_CONFIG_H to HAVE_ASN1C_CONFIG_H #202

Closed

Conversation

mtfurlan
Copy link

other projects like CppUTest also use HAVE_CONFIG_H so this will reduce
conflicts

Closes #201

other projects like CppUTest also use HAVE_CONFIG_H so this will reduce
conflicts
@mtfurlan
Copy link
Author

Hm, I didn't expect this to fail to build, but clearly I did it wrong

@mtfurlan
Copy link
Author

Okay so HAVE_CONFIG_H is generated by autotools with configure.ac:AC_CONFIG_HEADER([config.h])

So to do this we would have to rename config.h to config_asn1c.h
Is this still acceptable?

@mtfurlan
Copy link
Author

Okay I think HAVE_CONFIG_H is hardcoded by autoreconf and cannot be changed?

@mouse07410
Copy link
Owner

Now, wait a bit. Why are we interfering with the asn1c compiler build? It's not supposed to get linked with any other package out library, so whatever config.h other oxidates might have, should play no role here.

What are you trying to accomplish?

@kentkost
Copy link

I agree. It seems like more code is being added in order to fix something that is a "slight annoyance".
cpputest is not even used in asn1c.

What are you trying to accomplish?

@mtfurlan
Copy link
Author

I'm generating asn1c, adding the files to a cmake target, and then linking that target against my code, my tests, and cpputest, and somehow HAVE_CONFIG_H is getting set by them

It seemed silly that two projects were using the same name for something, but now that I've read autoconf I'm pretty sure the name is set by them, so we cannot change it

@mtfurlan mtfurlan closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we rename HAVE_CONFIG_H?
3 participants