JER decoder #144
Merged
JER decoder #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides JSON decoding support.
This is a basic implementation mostly tested against the output of
jer_encode.It should be able to decode anything that the current JSON encoder outputs.
Similarly to the encoder, the decoder also exhibits some issues. The problematic types include, but may not be limited to,
ANY,BMPString,SET,RELATIVE-OID,UniversalString, andNULL.While some issues may be relatively easy to fix, I have excluded their resolution from this PR as they impact both the encoder and decoder.
I'll also try to add some tests in the meanwhile.