Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --retry and --timeout flags #6

Merged
merged 2 commits into from
Sep 7, 2020
Merged

feat: add --retry and --timeout flags #6

merged 2 commits into from
Sep 7, 2020

Conversation

moul
Copy link
Owner

@moul moul commented Sep 6, 2020

addresses #3

@auto-add-label auto-add-label bot added the enhancement New feature or request label Sep 6, 2020
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 6, 2020
@codecov
Copy link

codecov bot commented Sep 6, 2020 •
edited
Loading

Codecov Report

Merging #6 into master will decrease coverage by 5.17%.
The diff coverage is 4.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   15.54%   10.36%   -5.18%     
==========================================
  Files           2        1       -1     
  Lines         148      164      +16     
==========================================
- Hits           23       17       -6     
- Misses        125      147      +22
Flag Coverage Δ
#unittests 10.36% <4.54%> (-5.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 10.36% <4.54%> (-0.35%) ⬇️
examples/testpkg/testpkg.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72bf7b8...ca7ef5b. Read the comment docs.

@moul moul self-assigned this Sep 6, 2020
@moul-bot moul-bot force-pushed the dev/moul/retry branch 2 times, most recently from 251d93c to 0ac2caa Compare September 6, 2020 23:56
@moul moul marked this pull request as ready for review September 7, 2020 00:02
@moul-bot moul-bot force-pushed the dev/moul/retry branch 2 times, most recently from 1dd4eb4 to 05deb30 Compare September 7, 2020 00:35
moul added 2 commits September 7, 2020 02:39
@moul
chore: bump deps
017f140 
Signed-off-by: Manfred Touron <[email protected]>
@moul
feat: add --retry and --timeout flags
ca7ef5b 
Signed-off-by: Manfred Touron <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 7, 2020 •
edited by moul
Loading

Expected release notes (by @moul-bot)

features:
add --retry and --timeout flags (ca7ef5b)

others (will not be included in Semantic-Release notes):
bump deps (017f140)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@moul moul merged commit 1ba3c46 into master Sep 7, 2020
@moul moul deleted the dev/moul/retry branch September 7, 2020 00:42
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Sep 7, 2020
@github-actions
Copy link

github-actions bot commented Sep 7, 2020

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@moul moul mentioned this pull request Sep 9, 2020
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@moul moul

Labels
enhancement New feature or request ✨ Merged Pull Request has been merged successfully released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@moul