Added GlobalHotKeysWithOptions class #492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenArg
changed the title
StephenArg
commented
Jul 22, 2022
| HotKey(HotKey.parse(key), value) | ||
| for key, value in hotkeys.items()] | ||
| HotKey(HotKey.parse(key), func) | ||
| for key, func in hotkeys.items()] |
There was a problem hiding this comment.
I also renamed value to func for clarity
StephenArg
force-pushed
the
GlobalHotKeys-add-options-argument
branch
from
6a11ae2
to
b4e5150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optional dict currently checks for an
'any_press'value and runs all the functions in the provided list. Let me know if this is less cluttered for you.This seems better than adding a whole new wrapper class that does the same theGlobalHotKeysdoes except for being able to run functions after every press.Edit: I realized changing the arguments in the main class could be a breaking change for those using the *args and **kwargs for that class. I went with your suggestion of making a new class with similar functionality. It was a better idea.
What do you think?