[Certora] Verify delegation correctness #92
+290
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-morpho
changed the title
This was referenced Nov 8, 2024
QGarchery
reviewed
Nov 12, 2024
QGarchery
reviewed
Nov 19, 2024
[Certora] Delegation tweaks
QGarchery
previously approved these changes
Nov 20, 2024
MathisGD
reviewed
Nov 23, 2024
Comment on lines
+22
to
+24
| // Safe requires because the proxy contract should be initialized right after construction. | ||
| require totalSupply() == 0; | ||
| require sumOfVotingPower == 0; |
There was a problem hiding this comment.
I don't understand the comment nor why it's ok to require this
There was a problem hiding this comment.
We expect the contract to be used behind a proxy, and the proxy to call initialize when it is constructed. The comment explains that, and highlights the fact that no calls to the contract are made in between construction and initialization
There was a problem hiding this comment.
I'll let @QGarchery change this comment, if need be, as he's the original author.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verification ensures that delegation of voting power accounting is correct.
Replaces #85
TODO: