Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcc-13 build failure (missing <cstdint> include) #229

Closed
wants to merge 1 commit into from
Closed

Fix gcc-13 build failure (missing <cstdint> include) #229

wants to merge 1 commit into from

Conversation

trofi
Copy link

@trofi trofi commented Feb 10, 2024

Without the change build on gcc-13 fails as:

In file included from /build/source/tests/unit/TestKafkaMetrics.cc:1:
/build/source/include/kafka/addons/KafkaMetrics.h:46:22: error: 'int64_t' is not a member of 'std'; did you mean 'int64_t'?
   46 |     ResultsType<std::int64_t> getInt(const KeysType& keys) const { return get<std::int64_t>(keys); }
      |                      ^~~~~~~

Without the change build on `gcc-13` fails as:

    In file included from /build/source/tests/unit/TestKafkaMetrics.cc:1:
    /build/source/include/kafka/addons/KafkaMetrics.h:46:22: error: 'int64_t' is not a member of 'std'; did you mean 'int64_t'?
       46 |     ResultsType<std::int64_t> getInt(const KeysType& keys) const { return get<std::int64_t>(keys); }
          |                      ^~~~~~~
@kenneth-jia
Copy link
Contributor

Hi, @trofi, Thank you for pointing it out! Your fix has been merged together with PR #232. Cheers!

@trofi trofi closed this Jul 3, 2024
@trofi trofi deleted the gcc-13-fix branch July 3, 2024 09:50
@alex-q-chen
Copy link
Member

alex-q-chen commented Jul 3, 2024

v2024.07.03 contains the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants