Use version objects when handling version numbers #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides using decimal numbers as package version number, it's also possible to use the dotted-decimal form (i.e. vX.Y.Z) in Perl. Currently, MooseX::Storage uses direct numeric comparison of the version strings which doesn't really work and it also spews "Argument ... isn't numeric in ..." warnings should the class define its version in dotted-decimal form. With this patch we're now creating version objects from the version strings, which accepts both decimal and dotted-decimal version formats as input and handles the comparison correctly.
|
Can you clarify when this problem would occur? CPAN::Meta::Spec (https://metacpan.org/pod/CPAN::Meta::Spec#VERSION-NUMBERS) says that '1.2.3' is an illegal version format -- versions should be either numeric, or bare v-strings, either of which should compare properly using the numeric operator. |
karenetheridge
force-pushed
the
master
branch
from
45d247a
to
8a1608b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides using decimal numbers as package version number, it's also
possible to use the dotted-decimal form (i.e. vX.Y.Z) in Perl.
Currently, MooseX::Storage uses direct numeric comparison of the version
strings which doesn't really work and it also spews
"Argument ... isn't numeric in ..." warnings should the class define its
version in dotted-decimal form. With this patch we're now creating
version objects from the version strings, which accepts both decimal
and dotted-decimal version formats as input and handles the comparison
correctly.