-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test operators appears in pallet session after bridging #777
Open
nanocryk
wants to merge
7
commits into
parth-add-support-for-eth-to-starlight-message-passing
Choose a base branch
from
jeremy-eth-bridge-test-session
base: parth-add-support-for-eth-to-starlight-message-passing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Test operators appears in pallet session after bridging #777
nanocryk
wants to merge
7
commits into
parth-add-support-for-eth-to-starlight-message-passing
from
jeremy-eth-bridge-test-session
+163
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanocryk
added
a0-pleasereview
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
D2-notlive
PR doesn't change runtime/client code
not-breaking
Does not need to be mentioned in breaking changes
labels
Dec 4, 2024
WASM runtime size check:Compared to target branchdancebox runtime: 1424 KB (no changes) ✅ flashbox runtime: 820 KB (no changes) ✅ dancelight runtime: 2104 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## parth-add-support-for-eth-to-starlight-message-passing jeremy-eth-bridge-test-session +/- ##
=================================================================================================================
Coverage 64.57% 64.57% 0.00%
Files 320 320
Lines 55407 55407
=================================================================================================================
Hits 35777 35777
Misses 19630 19630
|
tmpolaczyk
approved these changes
Dec 5, 2024
ParthDesai
force-pushed
the
parth-add-support-for-eth-to-starlight-message-passing
branch
from
December 6, 2024 08:37
dca3c6e
to
dac326a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a0-pleasereview
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
D2-notlive
PR doesn't change runtime/client code
not-breaking
Does not need to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test that validators inserted from Ethereum bridge are actually used by pallet session.
To be merged in #772, or rebase on master once #772 is merged.