Benchmark for on_container_author_noted only #767
+264
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanocryk
added
a0-pleasereview
WASM runtime size check:Compared to target branchdancebox runtime: 1424 KB (no changes) ✅ flashbox runtime: 820 KB (no changes) ✅ dancelight runtime: 2104 KB (+2104 KB) container chain template simple runtime: 1124 KB (-4296 KB) ✅ container chain template frontier runtime: 1400 KB (-5152 KB) ✅ |
Coverage Report@@ Coverage Diff @@
## master jeremy-bench-on-container-author-noted +/- ##
=========================================================================
Coverage 64.56% 64.56% 0.00%
Files 320 320
+ Lines 55422 55423 +1
=========================================================================
+ Hits 35781 35782 +1
Misses 19641 19641
|
girazoki
reviewed
Nov 29, 2024
| @@ -137,6 +137,14 @@ benchmarks! { | |||
| assert_ok!(Pallet::<T>::set_author(RawOrigin::Root.into(), para_id, block_number, author, u64::from(block_number).into())); | |||
| }: _(RawOrigin::Root, para_id) | |||
|
|
|||
| on_container_author_noted { | |||
There was a problem hiding this comment.
we should run it no (run it once at least in your own machine)? this should appear now when we benchmark author-noting
There was a problem hiding this comment.
Yes I'll run it on my machine for now.
There was a problem hiding this comment.
Will you push the weights to the PR @nanocryk ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new bench will allow us to get a better idea of how much 1 author noting progress costs, and thus better estimate how much we can support in one block.
Do you see any issue removing the condition over
runtime-benchmarksfeatures in the runtimes?set_latest_author_datawill change weight but as it is Mandatory the weight hint doesn't matter IIRC.