-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark for on_container_author_noted only #767
base: master
Are you sure you want to change the base?
Conversation
WASM runtime size check:Compared to target branchdancebox runtime: 1424 KB (no changes) ✅ flashbox runtime: 820 KB (no changes) ✅ dancelight runtime: 2072 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master jeremy-bench-on-container-author-noted +/- ##
=========================================================================
Coverage 64.57% 64.57% 0.00%
- Files 320 317 -3
- Lines 55407 55358 -49
=========================================================================
- Hits 35777 35746 -31
- Misses 19630 19612 -18
|
@@ -137,6 +137,14 @@ benchmarks! { | |||
assert_ok!(Pallet::<T>::set_author(RawOrigin::Root.into(), para_id, block_number, author, u64::from(block_number).into())); | |||
}: _(RawOrigin::Root, para_id) | |||
|
|||
on_container_author_noted { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should run it no (run it once at least in your own machine)? this should appear now when we benchmark author-noting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I'll run it on my machine for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you push the weights to the PR @nanocryk ?
This new bench will allow us to get a better idea of how much 1 author noting progress costs, and thus better estimate how much we can support in one block.
Do you see any issue removing the condition over
runtime-benchmarks
features in the runtimes?set_latest_author_data
will change weight but as it is Mandatory the weight hint doesn't matter IIRC.