MOBILE-3371: Global Search #3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelDeMartin
force-pushed
the
MOBILE-3371
branch
2 times, most recently
from
52b4aaf
to
26514ed
Compare
NoelDeMartin
force-pushed
the
MOBILE-3371
branch
from
26514ed
to
b986772
Compare
dpalou
requested changes
Sep 6, 2023
src/core/classes/items-management/paginated-items-manager-source.ts
Outdated
Show resolved
Hide resolved
src/core/features/search/components/global-search-filters/global-search-filters.component.ts
Outdated
Show resolved
Hide resolved
src/core/features/search/components/global-search-filters/global-search-filters.component.ts
Show resolved
Hide resolved
src/core/features/search/components/global-search-filters/global-search-filters.component.ts
Show resolved
Hide resolved
dpalou
reviewed
Sep 6, 2023
NoelDeMartin
force-pushed
the
MOBILE-3371
branch
from
b986772
to
9ce9633
Compare
dpalou
reviewed
Sep 8, 2023
src/core/features/search/components/global-search-filters/global-search-filters.component.ts
Outdated
Show resolved
Hide resolved
src/core/features/search/components/global-search-filters/global-search-filters.component.ts
Show resolved
Hide resolved
dpalou
requested changes
Sep 8, 2023
NoelDeMartin
force-pushed
the
MOBILE-3371
branch
from
9ce9633
to
b805a28
Compare
Also improved storybook set up to test the new feature
NoelDeMartin
force-pushed
the
MOBILE-3371
branch
from
b805a28
to
e90af3c
Compare
|
@dpalou Other than what we already discussed, I've also implemented support for 2 new result types: side blocks and course sections. This is in a new commit, but all the other changes are mostly amended in the previous ones. I also had to rebase to resolve merge conflicts, so you may have to look into the commits again. |
dpalou
requested changes
Sep 14, 2023
src/core/features/course/components/course-format/course-format.ts
Outdated
Show resolved
Hide resolved
src/core/features/course/components/course-format/course-format.ts
Outdated
Show resolved
Hide resolved
NoelDeMartin
force-pushed
the
MOBILE-3371
branch
from
e90af3c
to
254dcb3
Compare
dpalou
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behat tests won't pass until MDL-56020 is integrated in core.