Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve slot config form for more flexibility #25

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Improve slot config form for more flexibility #25

merged 2 commits into from
Mar 19, 2024

Conversation

delyriand
Copy link
Member

Summary:

  • Change the slot config resolver to pass on the delivery method to change the default value if you wish
  • Add container around the slot config select to make it easy to add things before or after select

maximehuran
maximehuran requested changes Mar 19, 2024
View reviewed changes
assets/js/app.js Outdated Show resolved Hide resolved
assets/js/app.js Outdated Show resolved Hide resolved
assets/js/app.js Outdated Show resolved Hide resolved
assets/js/app.js Outdated Show resolved Hide resolved
@madamebiz madamebiz added Status: needs update This Issue/PR needs update and removed Status: needs review Needs review labels Mar 19, 2024
@delyriand delyriand force-pushed the feature/improve-slot-config-form branch from 442890a to 5f22a70 Compare March 19, 2024 09:30
@madamebiz madamebiz added Status: needs review Needs review and removed Status: needs update This Issue/PR needs update labels Mar 19, 2024
@delyriand delyriand merged commit 00ee560 into monsieurbiz:master Mar 19, 2024
11 of 13 checks passed
@delyriand delyriand mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiwikoti Kiwikoti Kiwikoti approved these changes

@maximehuran maximehuran maximehuran approved these changes

@lanfisis lanfisis lanfisis approved these changes

Assignees
No one assigned
Labels
Status: needs review Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@delyriand @lanfisis @maximehuran @Kiwikoti @madamebiz