Changes to sidecar to fix some issues #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dont think the way we deal with file is safe, we should create a new one then rename it to the old one. This way this is atomic. |
|
Great suggestion, @roidelapluie. The current implementation in master is simply broken whenever you write the second time, even ignoring race conditions, so what @allenmqcymp is proposing is a net-improvement IMO. In any case, @allenmqcymp, if you are up for it, implementing the solution @roidelapluie suggests would be even better :) |
|
@roidelapluie @squat latest commit does just that. PTAL :) |
squat
reviewed
Nov 18, 2020
squat
reviewed
Nov 18, 2020
squat
reviewed
Nov 18, 2020
squat
reviewed
Nov 18, 2020
squat
reviewed
Nov 18, 2020
cmd/mixtool/server.go
Outdated
| if err != nil { | ||
| return false, fmt.Errorf("create rule file: %w", err) | ||
| } | ||
| fileData, err := ioutil.ReadFile(p.ruleFile) |
There was a problem hiding this comment.
Rather than reading both rule files completely into memory, i think it could be better to:
- Write the new rules to a temp file
- Get a file pointer to the old file
- Compare the readers for both files using the existing helper fun
- If equal, return early
- If not equal, rename the temp file
|
Looks good, only needs a rebase to get rid of the conflict in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on reloading rule files, I noticed two errors.
The PR fixes both the issues