test: Fixes DUPLICATE_CLUSTER_NAME failures (#2424)

* test: fix DUPLICATE_CLUSTER_NAME online_archive * test: fix DUPLICATE_CLUSTER_NAME backup_snapshot_restore_job
mongodb · Jul 16, 2024 · f9a1809 · f9a1809
1 parent 3f45cca
commit f9a1809
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 16 deletions.
diff --git a/.../service/cloudbackupsnapshotrestorejob/resource_cloud_backup_snapshot_restore_job_test.go b/.../service/cloudbackupsnapshotrestorejob/resource_cloud_backup_snapshot_restore_job_test.go
@@ -18,11 +18,13 @@ const (
 	dataSourceName = "data.mongodbatlas_cloud_backup_snapshot_restore_job.test"
 )
 
-var clusterRequest = acc.ClusterRequest{
-	CloudBackup: true,
-	ReplicationSpecs: []acc.ReplicationSpecRequest{
-		{Region: "US_WEST_2"},
-	},
+func clusterRequest() *acc.ClusterRequest {
+	return &acc.ClusterRequest{
+		CloudBackup: true,
+		ReplicationSpecs: []acc.ReplicationSpecRequest{
+			{Region: "US_WEST_2"},
+		},
+	}
 }
 
 func TestAccCloudBackupSnapshotRestoreJob_basic(t *testing.T) {
@@ -31,7 +33,7 @@ func TestAccCloudBackupSnapshotRestoreJob_basic(t *testing.T) {
 
 func TestAccCloudBackupSnapshotRestoreJob_basicDownload(t *testing.T) {
 	var (
-		clusterInfo         = acc.GetClusterInfo(t, &clusterRequest)
+		clusterInfo         = acc.GetClusterInfo(t, clusterRequest())
 		clusterName         = clusterInfo.ClusterName
 		description         = fmt.Sprintf("My description in %s", clusterName)
 		retentionInDays     = "1"
@@ -66,7 +68,7 @@ func basicTestCase(tb testing.TB) *resource.TestCase {
 	var (
 		snapshotsDataSourceName           = "data.mongodbatlas_cloud_backup_snapshot_restore_jobs.test"
 		snapshotsDataSourcePaginationName = "data.mongodbatlas_cloud_backup_snapshot_restore_jobs.pagination"
-		clusterInfo                       = acc.GetClusterInfo(tb, &clusterRequest)
+		clusterInfo                       = acc.GetClusterInfo(tb, clusterRequest())
 		clusterName                       = clusterInfo.ClusterName
 		description                       = fmt.Sprintf("My description in %s", clusterName)
 		retentionInDays                   = "1"

diff --git a/internal/service/onlinearchive/resource_online_archive_migration_test.go b/internal/service/onlinearchive/resource_online_archive_migration_test.go
@@ -12,7 +12,7 @@ import (
 func TestMigBackupRSOnlineArchiveWithNoChangeBetweenVersions(t *testing.T) {
 	var (
 		onlineArchiveResourceName = "mongodbatlas_online_archive.users_archive"
-		clusterInfo               = acc.GetClusterInfo(t, &clusterRequest)
+		clusterInfo               = acc.GetClusterInfo(t, clusterRequest())
 		clusterName               = clusterInfo.ClusterName
 		projectID                 = clusterInfo.ProjectID
 		clusterTerraformStr       = clusterInfo.ClusterTerraformStr

diff --git a/internal/service/onlinearchive/resource_online_archive_test.go b/internal/service/onlinearchive/resource_online_archive_test.go
@@ -13,8 +13,8 @@ import (
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc"
 )
 
-var (
-	clusterRequest = acc.ClusterRequest{
+func clusterRequest() *acc.ClusterRequest {
+	return &acc.ClusterRequest{
 		ReplicationSpecs: []acc.ReplicationSpecRequest{
 			// Must use US_EAST_1 in dev for online_archive to work
 			{AutoScalingDiskGbEnabled: true, Region: "US_EAST_1"},
@@ -23,14 +23,13 @@ var (
 			"ArchiveTest": "true", "Owner": "test",
 		},
 	}
-)
-
+}
 func TestAccBackupRSOnlineArchive(t *testing.T) {
 	var (
 		onlineArchiveResourceName    = "mongodbatlas_online_archive.users_archive"
 		onlineArchiveDataSourceName  = "data.mongodbatlas_online_archive.read_archive"
 		onlineArchivesDataSourceName = "data.mongodbatlas_online_archives.all"
-		clusterInfo                  = acc.GetClusterInfo(t, &clusterRequest)
+		clusterInfo                  = acc.GetClusterInfo(t, clusterRequest())
 		clusterName                  = clusterInfo.ClusterName
 		projectID                    = clusterInfo.ProjectID
 		clusterTerraformStr          = clusterInfo.ClusterTerraformStr
@@ -127,7 +126,7 @@ func TestAccBackupRSOnlineArchive(t *testing.T) {
 
 func TestAccBackupRSOnlineArchiveBasic(t *testing.T) {
 	var (
-		clusterInfo               = acc.GetClusterInfo(t, &clusterRequest)
+		clusterInfo               = acc.GetClusterInfo(t, clusterRequest())
 		clusterResourceName       = clusterInfo.ClusterResourceName
 		clusterName               = clusterInfo.ClusterName
 		projectID                 = clusterInfo.ProjectID
@@ -175,7 +174,7 @@ func TestAccBackupRSOnlineArchiveWithProcessRegion(t *testing.T) {
 	var (
 		onlineArchiveResourceName   = "mongodbatlas_online_archive.users_archive"
 		onlineArchiveDataSourceName = "data.mongodbatlas_online_archive.read_archive"
-		clusterInfo                 = acc.GetClusterInfo(t, &clusterRequest)
+		clusterInfo                 = acc.GetClusterInfo(t, clusterRequest())
 		clusterResourceName         = clusterInfo.ClusterResourceName
 		clusterName                 = clusterInfo.ClusterName
 		projectID                   = clusterInfo.ProjectID
@@ -221,7 +220,7 @@ func TestAccBackupRSOnlineArchiveWithProcessRegion(t *testing.T) {
 
 func TestAccBackupRSOnlineArchiveInvalidProcessRegion(t *testing.T) {
 	var (
-		clusterInfo         = acc.GetClusterInfo(t, &clusterRequest)
+		clusterInfo         = acc.GetClusterInfo(t, clusterRequest())
 		clusterTerraformStr = clusterInfo.ClusterTerraformStr
 		cloudProvider       = "AWS"
 		clusterResourceName = clusterInfo.ClusterResourceName