Skip to content

Commit

Permalink
Merge branch 'master' into CLOUDP-260977_cluster_examples
Browse files Browse the repository at this point in the history
* master:
  chore: Deletes modules folder (#2435)
  refactor: avoid usage of github.com/go-test/deep (use `reflect.DeepEqual instead`) (#2427)
  chore: Bump tj-actions/verify-changed-files (#2430)
  chore: Bump actions/setup-go from 5.0.1 to 5.0.2 (#2431)
  chore: Bump github.com/aws/aws-sdk-go from 1.54.17 to 1.54.19 (#2432)
  chore: Bump github.com/zclconf/go-cty from 1.14.4 to 1.15.0 (#2433)
  • Loading branch information
lantoli committed Jul 17, 2024
2 parents 2bffd43 + 214b694 commit 837cf4f
Show file tree
Hide file tree
Showing 31 changed files with 51 additions and 971 deletions.
40 changes: 20 additions & 20 deletions .github/workflows/acceptance-tests-runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -309,7 +309,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand Down Expand Up @@ -349,7 +349,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand Down Expand Up @@ -382,7 +382,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -406,7 +406,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -428,7 +428,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand Down Expand Up @@ -473,7 +473,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -495,7 +495,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -517,7 +517,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -539,7 +539,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand Down Expand Up @@ -577,7 +577,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -604,7 +604,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand Down Expand Up @@ -633,7 +633,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand Down Expand Up @@ -678,7 +678,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand Down Expand Up @@ -715,7 +715,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -740,7 +740,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -762,7 +762,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -784,7 +784,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -811,7 +811,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand All @@ -835,7 +835,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
ref: ${{ inputs.ref || github.ref }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-changelog-entry-file.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
permissions: {}
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- run: make check-changelog-entry-file
6 changes: 3 additions & 3 deletions .github/workflows/code-health.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
permissions: {}
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- name: Build
Expand All @@ -30,7 +30,7 @@ jobs:
pull-requests: write # Needed by sticky-pull-request-comment
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- name: Unit Test
Expand All @@ -42,7 +42,7 @@ jobs:
- name: Checkout
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Install Go
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
cache: false # see https://github.com/golangci/golangci-lint-action/issues/807
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
fetch-depth: 0
- run: echo "GO_VERSION=$(cat .go-version)" >> "${GITHUB_ENV}"
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- name: go build
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
fetch-depth: 0
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- name: tflint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/jira-release-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Validation of version format, no pre-releases
run: |
echo "${{ inputs.version_number }}" | grep -P '^v\d+\.\d+\.\d+$'
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- run: make jira-release-version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ jobs:
with:
ref: ${{ inputs.version_number }}
- name: Set up Go
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- name: Import GPG key
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-script-and-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
with:
fetch-depth: 0
token: ${{ secrets.apix_bot_pat }}
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update-sdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
with:
go-version-file: 'go.mod'
- name: Update files
run: make tools update-atlas-sdk
- name: Verify Changed files
uses: tj-actions/verify-changed-files@11ea2b36f98609331b8dc9c5ad9071ee317c6d28
uses: tj-actions/verify-changed-files@79f398ac63ab46f7f820470c821d830e5c340ef9
id: verify-changed-files
- name: Create PR
uses: peter-evans/create-pull-request@c5a7806660adbe173f04e3e038b0ccdcd758773c
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_tf_compatibility_matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: make update-tf-compatibility-matrix
- name: Verify Changed files
uses: tj-actions/verify-changed-files@11ea2b36f98609331b8dc9c5ad9071ee317c6d28
uses: tj-actions/verify-changed-files@79f398ac63ab46f7f820470c821d830e5c340ef9
id: verify-changed-files
- name: Create PR
uses: peter-evans/create-pull-request@c5a7806660adbe173f04e3e038b0ccdcd758773c
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ terraform.tfplan
terraform.tfstate
.terraform.lock.hcl
bin/
modules-dev/
/pkg/
.vagrant/
*.backup
Expand Down
5 changes: 2 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ go 1.22

require (
github.com/andygrunwald/go-jira/v2 v2.0.0-20240116150243-50d59fe116d6
github.com/aws/aws-sdk-go v1.54.17
github.com/go-test/deep v1.1.1
github.com/aws/aws-sdk-go v1.54.19
github.com/hashicorp/go-changelog v0.0.0-20240318095659-4d68c58a6e7f
github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320
github.com/hashicorp/go-version v1.7.0
Expand All @@ -22,7 +21,7 @@ require (
github.com/mongodb-forks/digest v1.1.0
github.com/spf13/cast v1.6.0
github.com/stretchr/testify v1.9.0
github.com/zclconf/go-cty v1.14.4
github.com/zclconf/go-cty v1.15.0
go.mongodb.org/atlas v0.36.0
go.mongodb.org/atlas-sdk/v20240530002 v20240530002.0.0
go.mongodb.org/realm v0.1.0
Expand Down
8 changes: 4 additions & 4 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5/go.mod h1:wHh0iHkY
github.com/aws/aws-sdk-go v1.15.78/go.mod h1:E3/ieXAlvM0XWO57iftYVDLLvQ824smPP3ATZkfNZeM=
github.com/aws/aws-sdk-go v1.37.0/go.mod h1:hcU610XS61/+aQV88ixoOzUoG7v3b31pl2zKMmprdro=
github.com/aws/aws-sdk-go v1.44.122/go.mod h1:y4AeaBuwd2Lk+GepC1E9v0qOiTws0MIWAX4oIKwKHZo=
github.com/aws/aws-sdk-go v1.54.17 h1:ZV/qwcCIhMHgsJ6iXXPVYI0s1MdLT+5LW28ClzCUPeI=
github.com/aws/aws-sdk-go v1.54.17/go.mod h1:eRwEWoyTWFMVYVQzKMNHWP5/RV4xIUGMQfXQHfHkpNU=
github.com/aws/aws-sdk-go v1.54.19 h1:tyWV+07jagrNiCcGRzRhdtVjQs7Vy41NwsuOcl0IbVI=
github.com/aws/aws-sdk-go v1.54.19/go.mod h1:eRwEWoyTWFMVYVQzKMNHWP5/RV4xIUGMQfXQHfHkpNU=
github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d h1:xDfNPAt8lFiC1UJrqV3uuy861HCTo708pDMbjHHdCas=
github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d/go.mod h1:6QX/PXZ00z/TKoufEY6K/a0k6AhaJrQKdFe6OfVXsa4=
github.com/bgentry/speakeasy v0.1.0 h1:ByYyxL9InA1OWqxJqqp2A5pYHUrCiAL6K3J+LKSsQkY=
Expand Down Expand Up @@ -770,8 +770,8 @@ github.com/zclconf/go-cty v1.1.0/go.mod h1:xnAOWiHeOqg2nWS62VtQ7pbOu17FtxJNW8RLE
github.com/zclconf/go-cty v1.2.0/go.mod h1:hOPWgoHbaTUnI5k4D2ld+GRpFJSCe6bCM7m1q/N4PQ8=
github.com/zclconf/go-cty v1.2.1/go.mod h1:hOPWgoHbaTUnI5k4D2ld+GRpFJSCe6bCM7m1q/N4PQ8=
github.com/zclconf/go-cty v1.8.2/go.mod h1:vVKLxnk3puL4qRAv72AO+W99LUD4da90g3uUAzyuvAk=
github.com/zclconf/go-cty v1.14.4 h1:uXXczd9QDGsgu0i/QFR/hzI5NYCHLf6NQw/atrbnhq8=
github.com/zclconf/go-cty v1.14.4/go.mod h1:VvMs5i0vgZdhYawQNq5kePSpLAoz8u1xvZgrPIxfnZE=
github.com/zclconf/go-cty v1.15.0 h1:tTCRWxsexYUmtt/wVxgDClUe+uQusuI443uL6e+5sXQ=
github.com/zclconf/go-cty v1.15.0/go.mod h1:VvMs5i0vgZdhYawQNq5kePSpLAoz8u1xvZgrPIxfnZE=
github.com/zclconf/go-cty-debug v0.0.0-20191215020915-b22d67c1ba0b/go.mod h1:ZRKQfBXbGkpdV6QMzT3rU1kSTAnfu1dO8dPKjYprgj8=
github.com/zclconf/go-cty-debug v0.0.0-20240509010212-0d6042c53940 h1:4r45xpDWB6ZMSMNJFMOjqrGHynW3DIBuR2H9j0ug+Mo=
github.com/zclconf/go-cty-debug v0.0.0-20240509010212-0d6042c53940/go.mod h1:CmBdvvj3nqzfzJ6nTCIwDTPZ56aVGvDrmztiO5g3qrM=
Expand Down
10 changes: 5 additions & 5 deletions internal/common/conversion/encode_state_test.go
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package conversion_test

import (
"reflect"
"testing"

"github.com/go-test/deep"
"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion"
)

Expand All @@ -16,8 +16,8 @@ func TestEncodeDecodeID(t *testing.T) {

got := conversion.DecodeStateID(conversion.EncodeStateID(expected))

if diff := deep.Equal(expected, got); diff != nil {
t.Fatalf("Bad testEncodeDecodeID return \n got = %#v\nwant = %#v \ndiff = %#v", got, expected, diff)
if !reflect.DeepEqual(expected, got) {
t.Fatalf("Bad testEncodeDecodeID return \n got = %#v\nwant = %#v", got, expected)
}
}

Expand All @@ -28,7 +28,7 @@ func TestDecodeID(t *testing.T) {
got := conversion.DecodeStateID(expected)
got2 := conversion.DecodeStateID(expected2)

if diff := deep.Equal(got, got2); diff != nil {
t.Fatalf("Bad TestDecodeID return \n got = %#v\nwant = %#v \ndiff = %#v", got, got2, diff)
if !reflect.DeepEqual(got, got2) {
t.Fatalf("Bad TestDecodeID return \n got = %#v\nwant = %#v", got, got2)
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package cloudbackupsnapshot_test

import (
"reflect"
"testing"

"github.com/go-test/deep"
"github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshot"
"go.mongodb.org/atlas-sdk/v20240530002/admin"
)
Expand All @@ -20,8 +20,8 @@ func TestSplitSnapshotImportID(t *testing.T) {
SnapshotId: "5cf5a45a9ccf6400e60981b7",
}

if diff := deep.Equal(expected, got); diff != nil {
t.Errorf("Bad splitSnapshotImportID return \n got = %#v\nwant = %#v \ndiff = %#v", expected, *got, diff)
if !reflect.DeepEqual(expected, got) {
t.Errorf("Bad splitSnapshotImportID return \n got = %#v\nwant = %#v", expected, *got)
}

if _, err := cloudbackupsnapshot.SplitSnapshotImportID("5cf5a45a9ccf6400e60981b6projectname-environment-mongo-global-cluster5cf5a45a9ccf6400e60981b7"); err == nil {
Expand Down
Loading

0 comments on commit 837cf4f

Please sign in to comment.