fix: Fixes mongodbatlas_ldap_configuration Delete function (#2221)

* disables LDAP in Delete * run in serial as ldap config is destroyed now in Delete
mongodb · Apr 30, 2024 · 36dc7a8 · 36dc7a8
1 parent 8ae5176
commit 36dc7a8
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/.changelog/2221.txt b/.changelog/2221.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/mongodbatlas_ldap_configuration: Disables LDAP when the resource is destroyed, instead of deleting userToDNMapping document 
+```
diff --git a/internal/service/ldapconfiguration/resource_ldap_configuration.go b/internal/service/ldapconfiguration/resource_ldap_configuration.go
@@ -242,7 +242,13 @@ func resourceUpdate(ctx context.Context, d *schema.ResourceData, meta any) diag.
 
 func resourceDelete(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics {
 	connV2 := meta.(*config.MongoDBClient).AtlasV2
-	_, _, err := connV2.LDAPConfigurationApi.DeleteLDAPConfiguration(ctx, d.Id()).Execute()
+	params := &admin.UserSecurity{
+		Ldap: &admin.LDAPSecuritySettings{
+			AuthenticationEnabled: conversion.Pointer(false),
+			AuthorizationEnabled:  conversion.Pointer(false),
+		},
+	}
+	_, _, err := connV2.LDAPConfigurationApi.SaveLDAPConfiguration(ctx, d.Id(), params).Execute()
 	if err != nil {
 		return diag.FromErr(fmt.Errorf(errorDelete, d.Id(), err))
 	}

diff --git a/internal/service/ldapconfiguration/resource_ldap_configuration_migration_test.go b/internal/service/ldapconfiguration/resource_ldap_configuration_migration_test.go
@@ -7,5 +7,5 @@ import (
 )
 
 func TestMigLDAPConfiguration_basic(t *testing.T) {
-	mig.CreateAndRunTest(t, basicTestCase(t))
+	mig.CreateAndRunTestNonParallel(t, basicTestCase(t))
 }
diff --git a/internal/service/ldapconfiguration/resource_ldap_configuration_test.go b/internal/service/ldapconfiguration/resource_ldap_configuration_test.go
@@ -19,7 +19,7 @@ const (
 )
 
 func TestAccLDAPConfiguration_basic(t *testing.T) {
-	resource.ParallelTest(t, *basicTestCase(t))
+	resource.Test(t, *basicTestCase(t))
 }
 
 func TestAccLDAPConfiguration_withVerify_CACertificateComplete(t *testing.T) {