DOP-4242: Use release, not tag push for CI/CD #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your feature branch infrastructure has been deployed! Your webhook URL is: https://z03hdnj1a6.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build For more information on how to use this endpoint, follow these instructions. |
mayaraman19
requested review from
branberry,
rayangler,
casthewiz and
seungpark
seungpark
requested changes
Jan 22, 2024
seungpark
approved these changes
Jan 24, 2024
README.md
Outdated
| @@ -157,7 +157,8 @@ docs-worker-pool contains various triggers for release to higher environments. C | |||
|
|
|||
| - Create release tags. We currently follow [semver](https://semver.org/) standards. | |||
| - If you don't have push access, open an issue or otherwise contact a contributor with administrator privileges. | |||
| - Verify that the deploy-production-ec2 workflow executed successfully for both job runs across both production instances. | |||
| - Create a release associated with the tag using the GitHub UI or by running `gh release create`. | |||
There was a problem hiding this comment.
might be an extra space at end of line, based on error
.github/workflows/README.md
Outdated
| @@ -2,6 +2,14 @@ | |||
|
|
|||
| This README describes the various workflows defined for the docs-worker-pool repository. | |||
|
|
|||
| ## Releases | |||
|
|
|||
| The release process occurs whenever someone releases a specific tag via the GitHub UI. Three separate workflows are run upon release: | |||
There was a problem hiding this comment.
minor nitpick. not specific to the Github UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOP-4242
This PR changes all instances of
on.push.tagtoon.releaseso that the CI/CD workflow is only activated upon release. please ignore the commit history 😭To test, I've created this dummy repository which has actions that are run only upon release. It seems to be working - feel free to clone, contribute, release, and play around with it.