Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-3977: encourage writers to switch webhooks 🥕 #902

Merged
merged 5 commits into from
Sep 7, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions api/controllers/v1/jobs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import { Batch } from '../../../src/services/batch';
import { notifyBuildSummary, snootyBuildComplete } from '../../handlers/jobs';

export const TriggerLocalBuild = async (event: any = {}, context: any = {}): Promise<any> => {

Check warning on line 16 in api/controllers/v1/jobs.ts

View workflow job for this annotation

GitHub Actions / test

Unexpected any. Specify a different type

Check warning on line 16 in api/controllers/v1/jobs.ts

View workflow job for this annotation

GitHub Actions / test

'context' is assigned a value but never used

Check warning on line 16 in api/controllers/v1/jobs.ts

View workflow job for this annotation

GitHub Actions / test

Unexpected any. Specify a different type
const client = new mongodb.MongoClient(c.get('dbUrl'));
await client.connect();
const db = client.db(c.get('dbName'));
Expand Down Expand Up @@ -166,13 +166,22 @@
jobId: string,
jobTitle: string,
status: string,
errorReason: string
errorReason: string,
jobType?: string
): string {
const msg = `Your Job (<${jobUrl}${jobId}|${jobTitle}>) `;
const env = c.get<string>('env');
switch (status) {
case 'inQueue':
return msg + 'has successfully been added to the ' + env + ' queue.';
// Encourage writers to update to new webhook on githubPush jobs
let inQueueMsg = msg;
if (jobType == 'githubPush') {
const webhookWikiUrl =
'https://wiki.corp.mongodb.com/display/DE/How-To%3A+Use+Snooty%27s+Autobuilder+to+Build+Your+Content';
const updatePlease = `:exclamation: You used the old webhook for this build. <${webhookWikiUrl}|Update to the new webhook> in your fork of this repo to save 90s per build.`;
inQueueMsg = updatePlease + '\n\n' + msg;
}
return inQueueMsg + 'has successfully been added to the ' + env + ' queue.';
case 'inProgress':
return msg + 'is now being processed.';
case 'completed':
Expand Down Expand Up @@ -213,7 +222,8 @@
jobId,
jobTitle,
fullDocument.status as string,
fullDocument?.error?.reason || ''
fullDocument?.error?.reason || '',
fullDocument?.payload.jobType
),
entitlement['slack_user_id']
);
Expand Down
Loading