DOP-3963: Render only latest version of spec at base spec component #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casthewiz
commented
Aug 30, 2023
casthewiz
commented
Aug 30, 2023
| @@ -192,7 +192,7 @@ describe('pageBuilder', () => { | |||
|
|
|||
| await buildOpenAPIPages(testEntries, testOptions); | |||
|
|
|||
| expect(mockExecute).toBeCalledTimes(testEntries.length * 2); | |||
| expect(mockExecute).toBeCalledTimes(4); | |||
There was a problem hiding this comment.
Given that we specify toBeCalledWith for each invocation, I'm fine with hardcoding the number of calls now that the logic isn't as straightforwards.
Open to any other equations that determine that intended number of calls though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
DOP-3963 has most details, but TLDR:
We want to render only the latest spec at the base route of any versioned OpenAPI spec - this resolves some out-of-order issues with resources in dropdowns vs version in the left sidenav, and consumers of the spec typically want to see the latest versions regardless.
Staging Link
https://mongodbcom-cdn.website.staging.corp.mongodb.com/docs-qa/atlas/master/reference/api-resources-spec/v2/