[DOP-3911]: Check project path for monorepo #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have been changed if head_commit is included
…ctories for organization
branberry
commented
Sep 6, 2023
| @@ -46,7 +46,7 @@ jobs: | |||
| cd cdk-infra/ | |||
| npm ci | |||
| npm run deploy:feature:stack -- -c env=stg -c customFeatureName=enhancedApp-stg-${{github.head_ref}} \ | |||
| auto-builder-stack-enhancedApp-stg-${{github.head_ref}}-webhook | |||
| auto-builder-stack-enhancedApp-stg-${{github.head_ref}}-webhooks | |||
There was a problem hiding this comment.
Fixes bug with feature branch update.
branberry
commented
Sep 6, 2023
|
|
||
| const docSetCollectionName = process.env.DOCS_SET_COLLECTION_NAME || 'docset'; | ||
|
|
||
| export class DocSetRepository extends BaseRepository { |
There was a problem hiding this comment.
Currently not used since the docset collection in Atlas is not yet configured, but we will need this functionality in the future.
branberry
commented
Sep 6, 2023
|
|
||
| // TODO: Populate these more. For DOP-3911, they are | ||
| // being added for testing purposes. | ||
| export interface DocSetEntry { |
There was a problem hiding this comment.
Currently incomplete, but this contains some of the type information that will be needed for the docset collection once it is created.
branberry
changed the title
rayangler
approved these changes
Sep 7, 2023
tests/unit/monorepo/monorepo.test.ts
Outdated
| expect(paths).toContain('server-docs/source/datalake'); | ||
| }); | ||
|
|
||
| it('Returns an empty array if there is no snooty.toml at in point in the file path', async () => { |
There was a problem hiding this comment.
at in point in the file path
Should this be "at any point" ?
There was a problem hiding this comment.
Nope! It should be in point, lol jk!! good catch, I'll update that 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DOP-3911
Description
Adds logic to find the project's path within the monorepo based on given file changes. This change supports detecting nested projects as well.
This PR also includes the functionality to check whether or not the project paths detected from GitHub match what is configured within the corresponding
docsetentry.This PR also includes small bugfixes/improvements:
Testing
https://3kxa3rkxf8.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/buildand the secret for pre-prod GitHub push jobs found on Parameter Store.docs-landingdirectoryNOTE: You will receive an error message stating that the build has failed. This is due to the autobuilder not having permission to clone the
docs-monoreporepository.