Code fence syntax highlight in readme #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Could you fix the pre-commit failures? https://github.com/mongodb-labs/mongo-arrow/actions/runs/8602051838/job/23578941507?pr=205#step:4:142
is this library solely concerned with reading? it does not handle numpy type conversion to BSON on DB write?
We support writing as well via the write() function:
https://mongo-arrow.readthedocs.io/en/stable/quickstart.html#writing-to-mongodb
|
pre-commit should be green now. thanks for the quick reply, good to know about |
|
Yes, you can see it here: https://github.com/mongodb-labs/mongo-arrow/blob/1.3.0/bindings/python/pymongoarrow/api.py#L417 |
ShaneHarvey
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick clarifying question if i may: is this library solely concerned with reading? it does not handle
numpytype conversion to BSON on DB write?context: it appears
numpy.bool_fails to BSON-serialize with numpy v2 materialsproject/fireworks#522