Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTPYTHON-450 Patch llama index test #53

Merged
merged 2 commits into from
Dec 16, 2024
Merged

INTPYTHON-450 Patch llama index test #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b82bbf
INTPYTHON-450 Patch llama index test
blink1073 Dec 16, 2024
5d607a8
fix langchain test
blink1073 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion langchain-python/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ ROOT_DIR=$(dirname $SCRIPT_DIR)
PYTHON_BINARY=$(find_python3)

# shellcheck disable=SC2164
cd libs/mongodb
cd libs/langchain-mongodb

$PYTHON_BINARY -m venv venv_pipeline
source venv_pipeline/bin/activate
Expand Down
13 changes: 13 additions & 0 deletions llama-index-python-vectorstore/patches/pin-test-output.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/llama-index-integrations/vector_stores/llama-index-vector-stores-mongodb/tests/test_vectorstore.py b/llama-index-integrations/vector_stores/llama-index-vector-stores-mongodb/tests/test_vectorstore.py
index b48869690..a803fb668 100644
--- a/llama-index-integrations/vector_stores/llama-index-vector-stores-mongodb/tests/test_vectorstore.py
+++ b/llama-index-integrations/vector_stores/llama-index-vector-stores-mongodb/tests/test_vectorstore.py
@@ -20,7 +20,7 @@ from .conftest import lock

def test_documents(documents: List[Document]) -> None:
"""Sanity check essay was found and documents loaded."""
- assert len(documents) == 23
+ assert len(documents) == 25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blink1073 Do we really want to use a patch for this? Was this change expected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I commented on the ticket. This patch will fail once there is a new release of llama-index-core, and we can remove it.

assert isinstance(documents[0], Document)


Loading