Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTPYTHON-309 & INTPYTHON-417 Use new cluster and schedule on interval #50

Merged
merged 57 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from 49 commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
68cd5c6
INTPYTHON-309 & INTPYTHON-417 Use new cluster and schedule on interval
blink1073 Nov 19, 2024
5b17bb3
fix config
blink1073 Nov 19, 2024
111ced2
fix config
blink1073 Nov 19, 2024
ed04fc4
debug
blink1073 Nov 19, 2024
ea81019
bug
blink1073 Nov 19, 2024
2443a55
try again
blink1073 Nov 19, 2024
f260636
try again
blink1073 Nov 20, 2024
749b416
try again
blink1073 Nov 20, 2024
3bda392
try again
blink1073 Nov 20, 2024
3434017
try again
blink1073 Nov 20, 2024
af656e3
fix secrets handling
blink1073 Nov 20, 2024
9a2093c
fix secrets handling
blink1073 Nov 20, 2024
f50115f
add missing file
blink1073 Nov 20, 2024
2b69ba3
fix llama_index
blink1073 Nov 20, 2024
7ae343e
fix secrets handling
blink1073 Nov 20, 2024
06a91d1
try old remote urls
blink1073 Nov 20, 2024
19da278
try old remote urls
blink1073 Nov 20, 2024
0cd1e0c
try old remote urls
blink1073 Nov 20, 2024
c4dcdd3
debug
blink1073 Nov 20, 2024
efba00e
try again with new cluster
blink1073 Nov 20, 2024
ab11405
set up cluster at startup
blink1073 Nov 20, 2024
ca14f16
fix remote setup
blink1073 Nov 20, 2024
c356168
fix remote setup
blink1073 Nov 20, 2024
ff80a59
fix remote setup
blink1073 Nov 20, 2024
11eef1c
patch min llama-index-core version
blink1073 Nov 21, 2024
688f5ca
see if all is working
blink1073 Nov 21, 2024
8e2e257
add waits
blink1073 Nov 21, 2024
04bef34
try 20sec
blink1073 Nov 21, 2024
77969cf
only create if it does not exist
blink1073 Nov 21, 2024
e9ada75
add debugging
blink1073 Nov 21, 2024
019be06
force debug logging
blink1073 Nov 21, 2024
ee2fc6c
run all variants
blink1073 Nov 21, 2024
94a7700
increase timeout
blink1073 Nov 21, 2024
1034e68
debug chatgpt
blink1073 Nov 21, 2024
4eb03ba
debug chatgpt
blink1073 Nov 21, 2024
42dcbd2
fix for python msk
blink1073 Nov 22, 2024
09f265f
update msk
blink1073 Nov 22, 2024
eaf685f
update msk
blink1073 Nov 22, 2024
b75ffbe
update docarray
blink1073 Nov 22, 2024
29b2493
update docarray
blink1073 Nov 22, 2024
b88b862
update langchain
blink1073 Nov 22, 2024
fa9ccb0
fix docarray
blink1073 Nov 22, 2024
4c7549e
try with clean db
blink1073 Nov 22, 2024
2ac1f31
increase timeout
blink1073 Nov 22, 2024
ea5ffe5
try not removing collections
blink1073 Nov 22, 2024
d08aafe
Merge branch 'main' of github.com:mongodb-labs/ai-ml-pipeline-testing…
blink1073 Nov 22, 2024
0e97128
fix collection handling
blink1073 Nov 22, 2024
1618a15
skip python semantic kernel
blink1073 Nov 22, 2024
5809946
lint
blink1073 Nov 22, 2024
83af185
address review
blink1073 Dec 2, 2024
8757c48
cleanup
blink1073 Dec 2, 2024
04926fb
fix remote handling
blink1073 Dec 2, 2024
c650983
fix local
blink1073 Dec 2, 2024
cf3c154
add more llama_index filters
blink1073 Dec 2, 2024
aa418b6
skip remote llama index
blink1073 Dec 2, 2024
620845f
skip remote llama index
blink1073 Dec 3, 2024
c4ad06e
remove new filters
blink1073 Dec 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 89 additions & 19 deletions .evergreen/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ functions:
params:
directory: "src"

"fetch secrets":
- command: subprocess.exec
type: setup
params:
working_dir: "src"
binary: bash
args: [.evergreen/fetch-secrets.sh]

"fetch repo":
- command: shell.exec
type: setup
Expand All @@ -54,58 +62,105 @@ functions:
add_expansions_to_env: true
working_dir: "src/${DIR}/${REPO_NAME}"
binary: bash
env:
atlas: ${workdir}/src/atlas/bin/atlas
args:
- ../run.sh

"setup atlas cli":
"setup local atlas":
- command: subprocess.exec
type: setup
retry_on_failure: true
params:
add_expansions_to_env: true
working_dir: "src"
binary: bash
env:
atlas: ${workdir}/src/atlas/bin/atlas
args:
- .evergreen/provision-atlas.sh

"setup remote atlas":
- command: subprocess.exec
type: setup
params:
add_expansions_to_env: true
working_dir: "src"
binary: bash
args: [.evergreen/setup-remote.sh]

pre_error_fails_task: true
pre:
- func: "fetch source"
- func: "setup atlas cli"
- func: "fetch secrets"

tasks:
- name: test-semantic-kernel-python
- name: test-semantic-kernel-python-local
commands:
- func: "fetch repo"
- func: "setup local atlas"
- func: "execute tests"

- name: test-semantic-kernel-python-remote
commands:
- func: "fetch repo"
- func: "setup remote atlas"
- func: "execute tests"

- name: test-semantic-kernel-csharp-local
commands:
- func: "fetch repo"
- func: "setup local atlas"
- func: "execute tests"

- name: test-semantic-kernel-csharp-remote
commands:
- func: "fetch repo"
- func: "setup remote atlas"
- func: "execute tests"

- name: test-langchain-python-local
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope for this ticket.

We should make a python generator for this as well. That or change this to just two tasks.
local run and remote run

There's no difference in the commands otherwise.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, replied to the wrong comment: https://jira.mongodb.org/browse/INTPYTHON-441

commands:
- func: "fetch repo"
- func: "setup local atlas"
- func: "execute tests"

- name: test-semantic-kernel-csharp
- name: test-langchain-python-remote
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add tags or can we do regex matching in evergreen to make sure these aren't run on pull requests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

commands:
- func: "fetch repo"
- func: "setup remote atlas"
- func: "execute tests"

- name: test-langchain-python
- name: test-chatgpt-retrieval-plugin-local
commands:
- func: "fetch repo"
- func: "setup local atlas"
- func: "execute tests"

- name: test-chatgpt-retrieval-plugin
- name: test-chatgpt-retrieval-plugin-remote
commands:
- func: "fetch repo"
- func: "setup remote atlas"
- func: "execute tests"

- name: test-llama-index
- name: test-llama-index-local
commands:
- func: "fetch repo"
- func: "setup local atlas"
- func: "execute tests"

- name: test-docarray
- name: test-llama-index-remote
commands:
- func: "fetch repo"
- func: "setup remote atlas"
- func: "execute tests"

- name: test-docarray-local
commands:
- func: "fetch repo"
- func: "setup local atlas"
- func: "execute tests"

- name: test-docarray-remote
commands:
- func: "fetch repo"
- func: "setup remote atlas"
- func: "execute tests"

buildvariants:
Expand All @@ -121,7 +176,10 @@ buildvariants:
run_on:
- rhel87-small
tasks:
- name: test-llama-index
- name: test-llama-index-local
- name: test-llama-index-remote
batchtime: 10080 # 1 week

- name: test-semantic-kernel-python-rhel
display_name: Semantic-Kernel RHEL Python
expansions:
Expand All @@ -132,7 +190,10 @@ buildvariants:
run_on:
- rhel87-small
tasks:
- name: test-semantic-kernel-python
- name: test-semantic-kernel-python-local
# TODO: INTPYTHON-430
# - name: test-semantic-kernel-python-remote
# batchtime: 10080 # 1 week

- name: test-semantic-kernel-csharp-rhel
display_name: Semantic-Kernel RHEL CSharp
Expand All @@ -144,7 +205,9 @@ buildvariants:
run_on:
- rhel87-small
tasks:
- name: test-semantic-kernel-csharp
- name: test-semantic-kernel-csharp-local
- name: test-semantic-kernel-csharp-remote
batchtime: 10080 # 1 week

- name: test-langchain-python-rhel
display_name: Langchain RHEL Python
Expand All @@ -156,7 +219,9 @@ buildvariants:
run_on:
- rhel87-small
tasks:
- name: test-langchain-python
- name: test-langchain-python-local
- name: test-langchain-python-remote
batchtime: 10080 # 1 week

- name: test-chatgpt-retrieval-plugin-rhel
display_name: ChatGPT Retrieval Plugin
Expand All @@ -168,7 +233,9 @@ buildvariants:
run_on:
- rhel87-small
tasks:
- name: test-chatgpt-retrieval-plugin
- name: test-chatgpt-retrieval-plugin-local
- name: test-chatgpt-retrieval-plugin-remote
batchtime: 10080 # 1 week

- name: test-llama-index-vectorstore-rhel
display_name: LlamaIndex RHEL Vector Store
Expand All @@ -180,7 +247,9 @@ buildvariants:
run_on:
- rhel87-small
tasks:
- name: test-llama-index
- name: test-llama-index-local
- name: test-llama-index-remote
batchtime: 10080 # 1 week

- name: test-docarray-rhel
display_name: DocArray RHEL
Expand All @@ -192,4 +261,5 @@ buildvariants:
run_on:
- rhel87-small
tasks:
- name: test-docarray
- name: test-docarray-local
- name: test-docarray-remote
9 changes: 9 additions & 0 deletions .evergreen/fetch-secrets.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/bin/bash

set -eu

# Clone drivers-evergeen-tools.
git clone https://github.com/mongodb-labs/drivers-evergreen-tools

# Get the secrets for drivers/ai-ml-pipeline-testing.
. drivers-evergreen-tools/.evergreen/secrets_handling/setup-secrets.sh drivers/ai-ml-pipeline-testing
13 changes: 11 additions & 2 deletions .evergreen/provision-atlas.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/bin/bash
set -eu

. .evergreen/utils.sh

Expand All @@ -9,15 +10,15 @@ EVERGREEN_PATH=$(pwd)/.evergreen
TARGET_DIR=$(pwd)/$DIR
SCAFFOLD_SCRIPT=$EVERGREEN_PATH/scaffold_atlas.py

set -ex
mkdir atlas

setup_local_atlas

cd atlas
pushd atlas

$PYTHON_BINARY -m venv .
source ./bin/activate
popd

# Test server is up
$PYTHON_BINARY -m pip install pymongo
Expand All @@ -29,5 +30,13 @@ DATABASE=$DATABASE \
CONN_STRING=$CONN_STRING \
REPO_NAME=$REPO_NAME \
DIR=$DIR \
DEBUG="${DEBUG:-1}" \
TARGET_DIR=$TARGET_DIR \
$PYTHON_BINARY $SCAFFOLD_SCRIPT

# Get the secrets.
source secrets-export.sh

# Create the env file
echo "export OPENAI_API_KEY=$OPENAI_API_KEY" >> env.sh
echo "export MONGODB_URI=$CONN_STRING" >> env.sh
89 changes: 85 additions & 4 deletions .evergreen/scaffold_atlas.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
import logging
import os
from pathlib import Path
from typing import Any, Union
from time import sleep, monotonic
from typing import Any, Callable, Union

from pymongo import MongoClient
from pymongo.database import Database
Expand All @@ -13,7 +14,7 @@

logging.basicConfig()
logger = logging.getLogger(__file__)
logger.setLevel(logging.DEBUG if os.environ.get("DEBUG") else logging.INFO)
logger.setLevel(logging.DEBUG)

DATABASE_NAME = os.environ.get("DATABASE")
CONN_STRING = os.environ.get("CONN_STRING")
Expand Down Expand Up @@ -41,12 +42,17 @@ def upload_data(db: Database, filename: Path) -> None:
db.name,
collection_name,
)
collections = [c["name"] for c in db.list_collections()]
if collection_name in collections:
logger.debug("Clearing existing collection", collection_name)
db[collection_name].delete_many({})
Comment on lines +46 to +48
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: We could also drop the collection entirely. This would remove all existing index definitions on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that but it seemed to cause race conditions.


if not isinstance(loaded_collection, list):
loaded_collection = [loaded_collection]
if loaded_collection:
result: InsertManyResult = db[collection_name].insert_many(loaded_collection)
logger.debug("Uploaded results for %s: %s", filename.name, result.inserted_ids)
else:
elif collection_name not in collections:
logger.debug("Empty collection named %s created", collection_name)
db.create_collection(collection_name)

Expand All @@ -66,12 +72,87 @@ def create_index(client: MongoClient, filename: Path) -> None:
index_name = loaded_index_configuration.pop("name")
index_type = loaded_index_configuration.pop("type", None)

logger.debug(
"creating search index: %s on %s.%s...",
index_name,
database_name,
collection_name,
)
Comment on lines +75 to +80
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯


collection = client[database_name][collection_name]

search_index = SearchIndexModel(
loaded_index_configuration, name=index_name, type=index_type
)
collection.create_search_index(search_index)
indexes = [index["name"] for index in collection.list_search_indexes()]
if index_name not in indexes:
collection.create_search_index(search_index)

else:
logger.debug(
"search index already exists, updating: %s on %s.%s",
index_name,
database_name,
collection_name,
)
collection.update_search_index(index_name, loaded_index_configuration)

logger.debug("waiting for search index to be ready...")
wait_until_complete = 120
_wait_for_predicate(
predicate=lambda: _is_index_ready(collection, index_name),
err=f"Index {index_name} update did not complete in {wait_until_complete}!",
timeout=wait_until_complete,
)
logger.debug("waiting for search index to be ready... done.")

logger.debug(
"creating search index: %s on %s.%s... done",
index_name,
database_name,
collection_name,
)


def _is_index_ready(collection: Any, index_name: str) -> bool:
"""Check for the index name in the list of available search indexes.

This confirms that the specified index is of status READY.

Args:
collection (Collection): MongoDB Collection to for the search indexes
index_name (str): Vector Search Index name

Returns:
bool : True if the index is present and READY false otherwise
"""
search_indexes = collection.list_search_indexes(index_name)

for index in search_indexes:
if index["status"] == "READY":
return True
return False


def _wait_for_predicate(
predicate: Callable, err: str, timeout: float = 120, interval: float = 0.5
) -> None:
"""Generic to block until the predicate returns true.

Args:
predicate (Callable[, bool]): A function that returns a boolean value
err (str): Error message to raise if nothing occurs
timeout (float, optional): Wait time for predicate. Defaults to TIMEOUT.
interval (float, optional): Interval to check predicate. Defaults to DELAY.

Raises:
TimeoutError: _description_
"""
start = monotonic()
while not predicate():
if monotonic() - start > timeout:
raise TimeoutError(err)
sleep(interval)


def walk_directory(filepath) -> list[str]:
Expand Down
Loading