chore(NODE-6603): set errexit in install script and download prebuilt windows zstd #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
nbbeeken
approved these changes
Dec 4, 2024
| download_zstd() { | ||
| mkdir -p deps/zstd | ||
| ZSTD_VERSION=$(node -p "require('./package.json')['mongodb:zstd_version']") | ||
| is_windows=$(node -p "process.platform === 'win32'") |
nbbeeken
added
the
Primary Review
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Set errexit in install-zstd.sh.
This causes the install script to fail on windows because the tarball contains symlinks, which cannot be extracted. The symlink files are not source files, so the build worked without issues before this, but now that errexit is set, we cannot download and extract the zstd source code.
Instead, on windows we now download the prebuilt static library (which does not contain symlinks).
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run format:js && npm run format:rsscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript