Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-6586): add regression test to ensure compressionLevel works #46

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

A new regression test has been added to ensure that compressionLevel is respected by our C++ bindings.

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run format:js && npm run format:rs script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 3, 2024
@nbbeeken nbbeeken self-assigned this Dec 3, 2024
@nbbeeken nbbeeken merged commit 5097e88 into main Dec 3, 2024
40 checks passed
@nbbeeken nbbeeken deleted the NODE-6586-compressionLevel-test branch December 3, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants