feat(NODE-6588): add ssdlc to zstd #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
had a problem deploying
to
release
GitHub Actions
Failure
baileympearson
had a problem deploying
to
release
GitHub Actions
Failure
baileympearson
had a problem deploying
to
release
GitHub Actions
Failure
baileympearson
had a problem deploying
to
release
GitHub Actions
Failure
baileympearson
had a problem deploying
to
release
GitHub Actions
Failure
baileympearson
had a problem deploying
to
release
GitHub Actions
Failure
baileympearson
had a problem deploying
to
release
GitHub Actions
Failure
baileympearson
had a problem deploying
to
release
GitHub Actions
Failure
baileympearson
had a problem deploying
to
release
GitHub Actions
Failure
baileympearson
had a problem deploying
to
release
GitHub Actions
Failure
baileympearson
temporarily deployed
to
release
GitHub Actions
Inactive
baileympearson
force-pushed
the
ssdlc-implementation
branch
from
176a2d3 to
5073612
Compare
baileympearson
temporarily deployed
to
release
GitHub Actions
Inactive
baileympearson
temporarily deployed
to
release
GitHub Actions
Inactive
baileympearson
changed the title
baileympearson
temporarily deployed
to
release
GitHub Actions
Inactive
nbbeeken
reviewed
Nov 27, 2024
nbbeeken
added
the
Primary Review
nbbeeken
approved these changes
Nov 27, 2024
| # - name: Install Node and dependencies | ||
| # uses: mongodb-labs/drivers-github-tools/node/setup@v2 | ||
| # with: | ||
| # ignore_install_scripts: true |
There was a problem hiding this comment.
why do we ignore the install scripts here?
There was a problem hiding this comment.
We do the same for kerberos and mongodb-client-encryption.
By default, npm i on our packages with native bindings downloads a prebuilt copy of our C++ code (there is an install script) or attempts to compile the bindings. All we need for this step is the JS dependencies
nbbeeken
added
Team Review
aditi-khare-mongoDB
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
A passing SSDLC release run is available here: https://github.com/mongodb-js/zstd/actions/runs/12056025639
Note that we can't actually confirm everything looks right until we do an actual release and can inspect the contents of the SSDLC report in s3. Once this PR merges, I can run the beta release and we can confirm.
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run format:js && npm run format:rsscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript