Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shell-api): Fix support for sharded time series collections with getShardDistribution MONGOSH-1447 #2189

Merged
merged 13 commits into from
Oct 8, 2024

Conversation

gagik
Copy link
Contributor

@gagik gagik commented Oct 3, 2024

When the getShardDistribution command is invoked on a sharded time series collection, the output says that the collection is not actually sharded. If the user invokes the same command on the related bucket collection, it produces an incorrect output.

This PR fixes both.

@gagik gagik marked this pull request as ready for review October 4, 2024 09:09
@gagik gagik changed the title fix(shell-api): Add support for getShardDistribution with sharded time series collections MONGOSH-1447 fix(shell-api): Fix support for sharded time series collections with getShardDistribution MONGOSH-1447 Oct 4, 2024
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

packages/shell-api/src/collection.ts Outdated Show resolved Hide resolved
packages/shell-api/src/collection.ts Outdated Show resolved Hide resolved
packages/shell-api/src/collection.ts Outdated Show resolved Hide resolved
@gagik
Copy link
Contributor Author

gagik commented Oct 8, 2024

All the remaining failing CI tasks seem unrelated, going ahead 🤞

@gagik gagik merged commit 6c4a45e into main Oct 8, 2024
52 of 56 checks passed
@gagik gagik deleted the gagik/add-sharded-time-series-getshard branch October 8, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants