Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy-support): update proxy-support to latest version that works around erraneous expired certs in system CA #2173

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

gribnoysup
Copy link
Contributor

@addaleax
Copy link
Contributor

@gribnoysup Do you know if the issue still occurs with the OpenSSL X509_V_FLAG_PARTIAL_CHAIN flag set? The plan here was to skip the X.509 certificate parsing in devtools-shared once that was available to us in mongosh (which it now is) because of the quite significant startup perf overhead. If we can't avoid this problem through other means than sorting the certificates by expiration date, that might be quite a problem for us.

@gribnoysup
Copy link
Contributor Author

gribnoysup commented Sep 25, 2024

@addaleax is there a way to see which flags are applied when I'm using openssl cli? I didn't check for this flag explicitly because the issue seemed different (issuer is in the CA, not missing, but expired), but I can tell you that openssl connected with the CA list provided while Node.js TLS didn't, but I don't know if this is just something that was happening just because this option was enabled by default or not

@lerouxb
Copy link
Contributor

lerouxb commented Sep 25, 2024

This ticket certainly makes it look like the flag is NOT enabled by default openssl/openssl#7871

@addaleax
Copy link
Contributor

@lerouxb Yes, hence the PR to Node.js to add that flag: nodejs/node#54790

@gribnoysup If you didn't set that flag manually (-partial_chain) when using the CLI, I think it's safe to say that it's not set.

but I can tell you that openssl connected with the CA list provided while TLS didn't

Yeah, that's ... odd. As far as I could tell in the original investigation here, it's unfortunately not fully deterministic which certificates in the CA list OpenSSL ends up using. I'll try to see if I can reproduce the issue with expired certs using only the CLI and then see if that tells us something.

@gribnoysup
Copy link
Contributor Author

Thank you! I definitely might've done something wrong when testing, I'm very unfamiliar with openssl cli so had to google around a lot, so intereseted to learn how it goes for you

@addaleax addaleax merged commit af3b030 into main Sep 25, 2024
56 of 71 checks passed
@addaleax addaleax deleted the bump-devtools-connect-devtools-proxy-support branch September 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants